WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
135101
Add helper functions to dump the scrolling state tree from the debugger
https://bugs.webkit.org/show_bug.cgi?id=135101
Summary
Add helper functions to dump the scrolling state tree from the debugger
Simon Fraser (smfr)
Reported
2014-07-20 10:17:23 PDT
Add helper functions to dump the scrolling state tree from the debugger
Attachments
Patch
(2.96 KB, patch)
2014-07-20 10:18 PDT
,
Simon Fraser (smfr)
darin
: review+
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
(587.76 KB, application/zip)
2014-07-20 11:51 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2014-07-20 10:18:17 PDT
Created
attachment 235185
[details]
Patch
Darin Adler
Comment 2
2014-07-20 10:32:02 PDT
Comment on
attachment 235185
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=235185&action=review
> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:39 > +#ifndef NDEBUG > +#include <wtf/Text/CString.h> > +#endif
I think we should just include this unconditionally.
> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:254 > +#ifndef NDEBUG > +void showScrollingStateTree(const WebCore::ScrollingStateTree* tree)
Please add a blank line here.
> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:257 > + if (!tree) > + return;
Silent? Maybe print something for clarity?
> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:259 > + const WebCore::ScrollingStateNode* rootNode = tree->rootStateNode();
I would just do auto* here; the complete typename and const is utterly uninteresting.
> Source/WebCore/page/scrolling/ScrollingStateTree.cpp:272 > + if (!node) > + return;
Silent? Maybe print something for clarity?
> Source/WebCore/page/scrolling/ScrollingStateTree.h:111 > +#ifndef NDEBUG > +void showScrollingStateTree(const WebCore::ScrollingStateTree*); > +void showScrollingStateTree(const WebCore::ScrollingStateNode*); > +#endif
Does it really need to be in the header? Can’t we just put this at the top of the .cpp file?
Build Bot
Comment 3
2014-07-20 11:51:18 PDT
Comment on
attachment 235185
[details]
Patch
Attachment 235185
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/5735317537554432
New failing tests: media/W3C/audio/networkState/networkState_initial.html media/track/track-long-word-container-sizing.html
Build Bot
Comment 4
2014-07-20 11:51:20 PDT
Created
attachment 235189
[details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Simon Fraser (smfr)
Comment 5
2014-07-21 11:28:18 PDT
https://trac.webkit.org/r171307
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug