Bug 135081 - [iOS] ignore requests to set volume
Summary: [iOS] ignore requests to set volume
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-18 19:03 PDT by Eric Carlson
Modified: 2014-07-20 09:46 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (1.29 KB, patch)
2014-07-18 19:09 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-07-18 19:03:47 PDT
The iOS media player should ignore requests to change volume.
Comment 1 Eric Carlson 2014-07-18 19:09:52 PDT
Created attachment 235164 [details]
Proposed patch
Comment 2 WebKit Commit Bot 2014-07-18 22:26:08 PDT
Comment on attachment 235164 [details]
Proposed patch

Clearing flags on attachment: 235164

Committed r171259: <http://trac.webkit.org/changeset/171259>
Comment 3 WebKit Commit Bot 2014-07-18 22:26:11 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Darin Adler 2014-07-19 22:38:21 PDT
Comment on attachment 235164 [details]
Proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235164&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1113
> +#if PLATFORM(IOS)
> +    return;
> +#endif

This is a peculiar way to do it. In the many cases like this one we compile out the code rather than adding a return and leaving unreachable code after the return like this.
Comment 5 Eric Carlson 2014-07-20 09:46:51 PDT
(In reply to comment #4)
> (From update of attachment 235164 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235164&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:1113
> > +#if PLATFORM(IOS)
> > +    return;
> > +#endif
> 
> This is a peculiar way to do it. In the many cases like this one we compile out the code rather than adding a return and leaving unreachable code after the return like this.

Good point. Fixed in r171279: http://trac.webkit.org/changeset/171279