RESOLVED FIXED 135079
We don't provide an extension to the temp file used for uploads 
https://bugs.webkit.org/show_bug.cgi?id=135079
Summary We don't provide an extension to the temp file used for uploads
Oliver Hunt
Reported 2014-07-18 17:27:53 PDT
We don't provide an extension to the temp file used for uploads
Attachments
Patch (2.07 KB, patch)
2014-07-18 17:29 PDT, Oliver Hunt 		ap: review-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2014-07-18 17:29:19 PDT
Created attachment 235158 [details] Patch
Alexey Proskuryakov
Comment 2 2014-07-19 10:33:37 PDT
Comment on attachment 235158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235158&action=review > Source/WebKit2/UIProcess/WebPageProxy.cpp:3780 > + // FIXME: The sandbox extensions should be sent with the DidChooseFilesForOpenPanel message. This > + // is gated on a way of passing SandboxExtension::Handles in a Vector. We have that, SandboxExtension::HandleArray.
Alexey Proskuryakov
Comment 3 2014-07-19 10:34:23 PDT
Comment on attachment 235158 [details] Patch I think that we should use the HandleArray.
Oliver Hunt
Comment 4 2014-07-19 13:17:03 PDT
(In reply to comment #3) > (From update of attachment 235158 [details]) > I think that we should use the HandleArray. This is a duplicate of the same code path that is used for DidChooseFilesForOpenPanel, this function is simply IOS specific. The core bug here is that both messages don't pass the extensions explicitly, and that should be fixed separately
Alexey Proskuryakov
Comment 5 2014-07-19 14:35:00 PDT
Why should it be fixed separately? The fix should be straightforward, even simpler than the workaround that you are suggesting here.
Oliver Hunt
Comment 6 2014-07-20 00:09:26 PDT
(In reply to comment #5) > Why should it be fixed separately? The fix should be straightforward, even simpler than the workaround that you are suggesting here. This code is a duplicate of the code below it, which is already well tested. The only difference is that this "new" code is in an iOS only code path that does not have this piece of logic. The "simpler" implementation requires changing the idl, and multiple methods to do a new and untested thing.
Oliver Hunt
Comment 7 2014-07-21 10:09:39 PDT
Committed r171257: <http://trac.webkit.org/changeset/171257>
Alexey Proskuryakov
Comment 8 2014-07-21 10:30:54 PDT
Seriously, committed an r-'ed patch?
Alexey Proskuryakov
Comment 9 2014-07-21 10:34:14 PDT
Oliver pointed out that this was committed before r-; it's just the comment that was posted now.
Note You need to log in before you can comment on or make changes to this bug.