Bug 135077 – _WKActivatedElementInfo.title should fallback to innerText if the link doesn't have title attribute.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Yongjun Zhang]

Often, a link might not have title attribute.  In that case, we should use the link element's innerText as a fallback.

[Yongjun Zhang]

<rdar://17373799>

[Yongjun Zhang]

Created attachment 235155 [details]
Fallback to link element's innerHTML if its title attribute is empty.

[Yongjun Zhang]

(In reply to comment #2)
> Created an attachment (id=235155) [details]
> Fallback to link element's innerHTML if its title attribute is empty.
typo, it should be innerText.

Comment on attachment 235155 [details]
Fallback to link element's innerHTML if its title attribute is empty.

View in context: https://bugs.webkit.org/attachment.cgi?id=235155&action=review

> Source/WebKit2/ChangeLog:6
> +        When populate InteractionInformationAtPosition's title value, use a link element's innerText if it

typo: populate->populating

[WebKit Commit Bot]

Comment on attachment 235155 [details]
Fallback to link element's innerHTML if its title attribute is empty.

Clearing flags on attachment: 235155

Committed r171253: <http://trac.webkit.org/changeset/171253>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Alexey Proskuryakov]

Isn't this kind of business logic something that should be in the client? WebKit's job is to provide all the necessary information, not to lie about what the title is.

(In reply to comment #7)
> Isn't this kind of business logic something that should be in the client? WebKit's job is to provide all the necessary information, not to lie about what the title is.

WebKit uses the title internally for its built-in Add to Reading List action. I do think we’ll need to review _WKActivatedElementInfo’s properties and their names if we make it a public class.