Bug 135065 - [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
Summary: [GTK] build-webkit script fails under jhbuild if ACLOCAL_FLAGS is unset
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-18 13:26 PDT by Michael Catanzaro
Modified: 2014-07-24 16:29 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.29 KB, patch)
2014-07-18 13:32 PDT, Michael Catanzaro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2014-07-18 13:26:05 PDT 
Looks like jhbuild-wrapper assumes that jhbuild sets ACLOCAL_FLAGS, but newer versions of jhbuild don't do this anymore.

$ Tools/Scripts/build-webkit --gtk --cmakeargs="-DCMAKE_PREFIX_PATH=/home/mcatanzaro/jhbuild/install"
which: no ninja in (/home/mcatanzaro/jhbuild/install/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/mcatanzaro/.local/bin:/home/mcatanzaro/bin)
which: no eclipse in (/home/mcatanzaro/jhbuild/install/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/bin:/usr/local/sbin:/usr/sbin:/home/mcatanzaro/.local/bin:/home/mcatanzaro/bin)
Traceback (most recent call last):
  File "/home/mcatanzaro/WebKit/Tools/jhbuild/jhbuild-wrapper", line 117, in <module>
    del os.environ['ACLOCAL_FLAGS']
  File "/usr/lib64/python2.7/os.py", line 496, in __delitem__
    del self.data[key]
KeyError: 'ACLOCAL_FLAGS'
Comment 1 Michael Catanzaro 2014-07-18 13:32:47 PDT 
Created attachment 235144 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-24 16:29:23 PDT 
Comment on attachment 235144 [details]
Patch

Clearing flags on attachment: 235144

Committed r171552: <http://trac.webkit.org/changeset/171552>
Comment 3 WebKit Commit Bot 2014-07-24 16:29:26 PDT 
All reviewed patches have been landed.  Closing bug.