RESOLVED FIXED 135059
Refactor run-jsc-stress-tests VM copying code to remove some abstractions 
https://bugs.webkit.org/show_bug.cgi?id=135059
Summary Refactor run-jsc-stress-tests VM copying code to remove some abstractions
Filip Pizlo
Reported 2014-07-18 12:05:56 PDT
Patch forthcoming.
Attachments
the patch (4.11 KB, patch)
2014-07-18 12:08 PDT, Filip Pizlo 		mark.lam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-07-18 12:08:44 PDT
Created attachment 235135 [details] the patch
Mark Lam
Comment 2 2014-07-18 12:10:55 PDT
Comment on attachment 235135 [details] the patch r=me
Filip Pizlo
Comment 3 2014-07-18 12:14:13 PDT
Landed in http://trac.webkit.org/changeset/171233
Carlos Alberto Lopez Perez
Comment 4 2014-07-18 14:37:21 PDT
This broke run-jsc-stress-tests on both EFL and GTK: Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError) from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal' from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>'
Filip Pizlo
Comment 5 2014-07-18 14:47:04 PDT
(In reply to comment #4) > This broke run-jsc-stress-tests on both EFL and GTK: > > Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError) > from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal' > from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>' I see it, fix on the way.
Filip Pizlo
Comment 6 2014-07-18 15:09:02 PDT
(In reply to comment #5) > (In reply to comment #4) > > This broke run-jsc-stress-tests on both EFL and GTK: > > > > Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError) > > from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal' > > from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>' > > I see it, fix on the way. Fixed in http://trac.webkit.org/changeset/171245
Note You need to log in before you can comment on or make changes to this bug.