Bug 135059 - Refactor run-jsc-stress-tests VM copying code to remove some abstractions
Summary: Refactor run-jsc-stress-tests VM copying code to remove some abstractions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-18 12:05 PDT by Filip Pizlo
Modified: 2014-07-18 15:09 PDT (History)
9 users (show)

See Also:


Attachments
the patch (4.11 KB, patch)
2014-07-18 12:08 PDT, Filip Pizlo
mark.lam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-07-18 12:05:56 PDT
Patch forthcoming.
Comment 1 Filip Pizlo 2014-07-18 12:08:44 PDT
Created attachment 235135 [details]
the patch
Comment 2 Mark Lam 2014-07-18 12:10:55 PDT
Comment on attachment 235135 [details]
the patch

r=me
Comment 3 Filip Pizlo 2014-07-18 12:14:13 PDT
Landed in http://trac.webkit.org/changeset/171233
Comment 4 Carlos Alberto Lopez Perez 2014-07-18 14:37:21 PDT
This broke run-jsc-stress-tests on both EFL and GTK:

Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError)
	from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal'
	from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>'
Comment 5 Filip Pizlo 2014-07-18 14:47:04 PDT
(In reply to comment #4)
> This broke run-jsc-stress-tests on both EFL and GTK:
> 
> Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError)
>     from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal'
>     from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>'

I see it, fix on the way.
Comment 6 Filip Pizlo 2014-07-18 15:09:02 PDT
(In reply to comment #5)
> (In reply to comment #4)
> > This broke run-jsc-stress-tests on both EFL and GTK:
> > 
> > Tools/Scripts/run-jsc-stress-tests:1058:in `prepareBundle': undefined local variable or method `jscPath' for main:Object (NameError)
> >     from Tools/Scripts/run-jsc-stress-tests:1420:in `runNormal'
> >     from Tools/Scripts/run-jsc-stress-tests:1452:in `<main>'
> 
> I see it, fix on the way.

Fixed in http://trac.webkit.org/changeset/171245