RESOLVED FIXED 135057
Add 'analyze' target to the Makefiles
https://bugs.webkit.org/show_bug.cgi?id=135057
Summary Add 'analyze' target to the Makefiles
Dana Burkart
Reported 2014-07-18 11:32:14 PDT
I would like to run the clang static analyzer from the command line, and have a per-project breakdown of the results. In order to do that, each xcodebuild invocation needs to be wrapped in a call to scan-build (http://clang-analyzer.llvm.org/scan-build.html). I have a patch which adds a new 'analyze' target to allow for this.
Attachments
Proposed patch. (3.94 KB, patch)
2014-07-18 11:36 PDT, Dana Burkart
dburkart: commit-queue-
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (531.73 KB, application/zip)
2014-07-18 12:49 PDT, Build Bot
no flags
Updated patch (5.48 KB, patch)
2014-07-18 15:15 PDT, Dana Burkart
ddkilzer: review+
dburkart: commit-queue-
Dana Burkart
Comment 1 2014-07-18 11:36:21 PDT
Created attachment 235132 [details] Proposed patch. I've attached a patch to accomplish this.
Build Bot
Comment 2 2014-07-18 12:49:24 PDT
Comment on attachment 235132 [details] Proposed patch. Attachment 235132 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5848274372132864 New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html
Build Bot
Comment 3 2014-07-18 12:49:26 PDT
Created attachment 235141 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Dana Burkart
Comment 4 2014-07-18 15:15:24 PDT
Created attachment 235150 [details] Updated patch Updated patch to output static analysis to the command line if PATH_TO_SCAN_BUILD is not set.
David Kilzer (:ddkilzer)
Comment 5 2014-07-18 15:26:40 PDT
Comment on attachment 235150 [details] Updated patch View in context: https://bugs.webkit.org/attachment.cgi?id=235150&action=review r=me > Makefile.shared:28 > > + Unintentional blank lined added? > Makefile.shared:41 > +analyze: > + $(SCRIPTS_PATH)/set-webkit-configuration --release It would be nice if we could support analyze with --debug builds as well. Maybe add a STYLE=debug argument to the make command such that unset STYLE defaults to 'release', but lets you override to 'debug'. This can be added later, though.
Mark Rowe (bdash)
Comment 6 2014-08-26 20:01:23 PDT
Was this landed?
Dana Burkart
Comment 7 2014-08-27 16:41:43 PDT
Yes, this was landed.
Note You need to log in before you can comment on or make changes to this bug.