Bug 135031 – Fixed position elements are misplaced when a WK1 view has contentInsets set

• Status: NEW
• Component: Layout and Rendering

[Beth Dakin]

Fixed position elements are misplaced when a WK1 view has contentInsets set.

<rdar://problem/17682335>

[Beth Dakin]

Created attachment 235098 [details]
Patch

[Tim Horton]

Comment on attachment 235098 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235098&action=review

> Source/WebCore/platform/mac/ScrollViewMac.mm:127
> +        IntSize frameSize = IntSize([scrollView() frame].size);

No need for the " = IntSize"

> Source/WebCore/platform/mac/ScrollViewMac.mm:135
>      END_BLOCK_OBJC_EXCEPTIONS;

does this need to be before return? I think it might, but I am not sure

> Source/WebCore/platform/mac/ScrollViewMac.mm:137
>      return IntRect();

why is this still here?

[Beth Dakin]

(In reply to comment #2)
> (From update of attachment 235098 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235098&action=review
> 
> > Source/WebCore/platform/mac/ScrollViewMac.mm:127
> > +        IntSize frameSize = IntSize([scrollView() frame].size);
> 
> No need for the " = IntSize"
> 

Fixed.

> > Source/WebCore/platform/mac/ScrollViewMac.mm:135
> >      END_BLOCK_OBJC_EXCEPTIONS;
> 
> does this need to be before return? I think it might, but I am not sure
> 
> > Source/WebCore/platform/mac/ScrollViewMac.mm:137
> >      return IntRect();
> 
> why is this still here?

Both of these have the same answer: this is what the function previously did. It had the normal return statement just before END_BLOCK_OBJC_EXCEPTIONS, and then a generic return after. Other functions in ScrollViewMac that return things follow this convention as well.

[Tim Horton]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 235098 [details] [details])
> > View in context: https://bugs.webkit.org/attachment.cgi?id=235098&action=review
> > 
> > > Source/WebCore/platform/mac/ScrollViewMac.mm:127
> > > +        IntSize frameSize = IntSize([scrollView() frame].size);
> > 
> > No need for the " = IntSize"
> > 
> 
> Fixed.
> 
> > > Source/WebCore/platform/mac/ScrollViewMac.mm:135
> > >      END_BLOCK_OBJC_EXCEPTIONS;
> > 
> > does this need to be before return? I think it might, but I am not sure
> > 
> > > Source/WebCore/platform/mac/ScrollViewMac.mm:137
> > >      return IntRect();
> > 
> > why is this still here?
> 
> Both of these have the same answer: this is what the function previously did. It had the normal return statement just before END_BLOCK_OBJC_EXCEPTIONS, and then a generic return after. Other functions in ScrollViewMac that return things follow this convention as well.

Because that's what they do when they get an exception inside the blocking block. Okie!

[Beth Dakin]

Created attachment 235148 [details]
Patch that does not break Yosemite tests

[Csaba Osztrogonác]

Comment on attachment 235098 [details]
Patch

Cleared Tim Horton's review+ from obsolete attachment 235098 [details] so that this bug does not appear in http://webkit.org/pending-commit.