Bug 135012 - Remove the unused variable in SubresourceLoader::willSendRequest()
Summary: Remove the unused variable in SubresourceLoader::willSendRequest()
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-17 01:00 PDT by Keonil Jeong
Modified: 2024-02-24 15:29 PST (History)
6 users (show)

See Also:

Attachments
Patch (1.38 KB, patch)
2014-07-17 01:30 PDT, Keonil Jeong 		no flags Details | Formatted Diff | Diff
Patch (1.44 KB, patch)
2014-07-17 01:39 PDT, Keonil Jeong 		no flags Details | Formatted Diff | Diff
Patch (1.65 KB, patch)
2014-07-30 17:09 PDT, Keonil Jeong 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keonil Jeong 2014-07-17 01:00:41 PDT 
In SubresourceLoader::willSendRequest(), the previousURL variable is no more necessary.
Comment 1 Keonil Jeong 2014-07-17 01:30:04 PDT 
Created attachment 235057 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-17 01:31:59 PDT 
Attachment 235057 [details] did not pass style-queue:


ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 1 in 1 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Keonil Jeong 2014-07-17 01:39:59 PDT 
Created attachment 235058 [details]
Patch
Comment 4 Keonil Jeong 2014-07-18 01:25:33 PDT 
the fail of window build is not related to this patch.
Comment 5 Keonil Jeong 2014-07-30 17:09:04 PDT 
Created attachment 235781 [details]
Patch
Comment 6 mitz 2014-08-01 21:22:10 PDT 
Comment on attachment 235781 [details]
Patch

I found that the last use of this variable was removed in <http://trac.webkit.org/r145735>.
Comment 7 Ahmad Saleem 2024-02-24 15:29:00 PST 
This didn't landed but I couldn't find the variable as well:

(SubresourceLoader::willSendRequestInternal)

https://searchfox.org/wubkat/rev/dc6a01c9fd207e1b1394a1cb8261b410a1909cf6/Source/WebCore/loader/SubresourceLoader.cpp#207