Before adding early return path for PseudoElement, we need to simplify the existing return path in CSS JIT.
Created attachment 235054 [details] Patch
Comment on attachment 235054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235054&action=review This looks correct to me. > Source/WebCore/cssjit/SelectorCompiler.cpp:1193 > + StackAllocator::StackReference baselineStackReference; I think "baseline" is a little too generic for the name. One could think it is the top of the stack for this function. What about startOfDiscardableStack, temporaryStackBase, ... or something like that? > Source/WebCore/cssjit/StackAllocator.h:156 > + void popAndDiscardUpToBaseline() > + { > + if (!m_offsetFromTop) > + return; > + m_assembler.addPtr(JSC::MacroAssembler::TrustedImm32(m_offsetFromTop), JSC::MacroAssembler::stackPointerRegister); > + m_offsetFromTop = 0; > + } > + This is unused.
Comment on attachment 235054 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235054&action=review Thank you for your comments. They are reasonable. I'll reflect your comments and land it :) >> Source/WebCore/cssjit/SelectorCompiler.cpp:1193 >> + StackAllocator::StackReference baselineStackReference; > > I think "baseline" is a little too generic for the name. One could think it is the top of the stack for this function. > > What about startOfDiscardableStack, temporaryStackBase, ... or something like that? Right. `temporaryStackBase` looks suitable for me :) I'll change it. >> Source/WebCore/cssjit/StackAllocator.h:156 >> + > > This is unused. Oops! Thank you, removing.
Committed r171177: <http://trac.webkit.org/changeset/171177>