Bug 135007 – sputnik/Implementation_Diagnostics/S12.6.4_D1.html depends on undefined behavior

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

EcmaScript 5.1 specifies that during for-in enumeration newly added properties may or may not be visited during the current enumeration. Specifically, in section 12.6.4 the spec states:

"If new properties are added to the object being enumerated during enumeration, the newly added properties are not guaranteed to be visited in the active enumeration."

The sputnik/Implementation_Diagnostics/S12.6.4_D1.html layout test is from before sputnik was added to the test262 suite. I believe it has since been removed, so it would probably be okay to remove it from our layout test suite.

[Mark Hahnenberg]

Created attachment 235049 [details]
Patch

[Filip Pizlo]

Comment on attachment 235049 [details]
Patch

Is it part of test262?

[Mark Hahnenberg]

(In reply to comment #2)
> (From update of attachment 235049 [details])
> Is it part of test262?

I don't think it is any more. I have a patch that breaks this test but the section 12 test262 tests pass.

[Mark Hahnenberg]

(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 235049 [details] [details])
> > Is it part of test262?
> 
> I don't think it is any more. I have a patch that breaks this test but the section 12 test262 tests pass.

I guess it might never have been added to test262 though...

[Mark Hahnenberg]

Fix landed in http://trac.webkit.org/changeset/171189.

[Mark Hahnenberg]

Comment on attachment 235049 [details]
Patch

Clearing review flag.