RESOLVED FIXED 135001
Web Inspector: TextContentView calls the wrong super function in shown() 
https://bugs.webkit.org/show_bug.cgi?id=135001
Summary Web Inspector: TextContentView calls the wrong super function in shown()
Saam Barati
Reported 2014-07-16 18:31:41 PDT
TextContentView calls ResourceContentView.shown instead of ContentView.shown. It should call ContentView.shown because ContentView is its prototype.
Attachments
patch (1.43 KB, patch)
2014-07-16 18:35 PDT, Saam Barati 		no flags
DetailsFormatted DiffDiff
patch (571 bytes, patch)
2014-07-17 11:22 PDT, Saam Barati 		timothy: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-07-16 18:31:54 PDT
<rdar://problem/17705592>
Saam Barati
Comment 2 2014-07-16 18:35:04 PDT
Created attachment 235042 [details] patch This fixes the problem. (Currently, calling the wrong prototype function has no effect, because neither function does anything. But this may not hold in the future).
Timothy Hatcher
Comment 3 2014-07-16 20:35:36 PDT
Comment on attachment 235042 [details] patch Nice catch!
WebKit Commit Bot
Comment 4 2014-07-16 21:08:07 PDT
Comment on attachment 235042 [details] patch Clearing flags on attachment: 235042 Committed r171172: <http://trac.webkit.org/changeset/171172>
WebKit Commit Bot
Comment 5 2014-07-16 21:08:10 PDT
All reviewed patches have been landed. Closing bug.
Joseph Pecoraro
Comment 6 2014-07-17 10:42:32 PDT
Comment on attachment 235042 [details] patch Err, the hidden function needs to be updated as well.
Saam Barati
Comment 7 2014-07-17 11:17:02 PDT
(In reply to comment #6) > (From update of attachment 235042 [details]) > Err, the hidden function needs to be updated as well. Ahh I didn't even see that. I'll submit that as a patch too.
Saam Barati
Comment 8 2014-07-17 11:22:45 PDT
Created attachment 235078 [details] patch Corollary patch for the hidden() function.
Joseph Pecoraro
Comment 9 2014-07-17 13:34:50 PDT
Comment on attachment 235078 [details] patch Unfortunately this needs a ChangeLog. So perhaps a new bugzilla bug is the right thing to do.
Note You need to log in before you can comment on or make changes to this bug.