Bug 134990 – Need FTL implementation of SkipTopScope

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Matthew Mirman]

patch forthcoming.

[Matthew Mirman]

Created attachment 235021 [details]
[ftlopt] Added SkipTopScope coverage to FTL

Can't test it yet though.

[WebKit Commit Bot]

Attachment 235021 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3394:  Extra space after ( in function call  [whitespace/parens] [4]
ERROR: Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3404:  Missing space after ,  [whitespace/comma] [3]
Total errors found: 2 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Geoffrey Garen]

Comment on attachment 235021 [details]
[ftlopt] Added SkipTopScope coverage to FTL

View in context: https://bugs.webkit.org/attachment.cgi?id=235021&action=review

r=me

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3421
> +            m_out.isZero64( m_out.load64(addressFor(machineActivationRegister)))

No space after the paren here.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3423
> +            , unsure(isNull)
> +            , unsure(notNull));

These two can probably go on the same line.

> Source/JavaScriptCore/ftl/FTLLowerDFGToLLVM.cpp:3431
> +        setJSValue(m_out.phi(m_out.intPtr, top,next));

Space after "top".

[Matthew Mirman]

Created attachment 235024 [details]
[ftlopt] Added SkipTopScope coverage to FTL

Fixed style

[Matthew Mirman]

Landed in http://trac.webkit.org/changeset/171767