Bug 134979 – REGRESSION(r171004): [GTK] 6 Layout test on media/track/track* fail

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Alberto Lopez Perez]

Revision r171004 <http://trac.webkit.org/r171004> has caused 6 failures on the media/track layout tests on the GTK port:


Regressions: Unexpected text-only failures (6)
  media/track/track-cue-mutable-text.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-mutable-text-pretty-diff.html
  media/track/track-cue-nothing-to-render.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-nothing-to-render-pretty-diff.html
  media/track/track-cue-rendering-mode-changed.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-mode-changed-pretty-diff.html
  media/track/track-cue-rendering-rtl.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-rtl-pretty-diff.html
  media/track/track-cue-rendering-snap-to-lines-not-set.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-snap-to-lines-not-set-pretty-diff.html
  media/track/track-kind.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-kind-pretty-diff.html

I double-checked that r171004 caused this: I tested to revert r171004 locally and the tests pass as expected.

[Brent Fulgham]

We probably need to add something like this to the generic "MediaControls.css" file: <http://trac.webkit.org/changeset/171004/trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css>

This additional <div> around the <span> might also be breaking the test you cited. You probably need to modify the test slightly so that it grabs the innerText from the right element.

[Carlos Alberto Lopez Perez]

I have marked this test as failing on the GTK TestExpectations on r171169 <http://trac.webkit.org/r171169>

[Marcos Chavarría Teijeiro (irc: chavaone)]

The layout test media/track/track-cue-rendering-mode-changed.html is flaky now and it timeouts sometimes.

Updating GTK test expectations on bug 143701.

[Michael Catanzaro]

Seems that media/track/track-kind.html was fixed by r195511. The other media track tests are still broken.

Calvaris, ChangeSeok, this seems related to your recent work; is this something you'd be interested in looking into?

[ChangSeok Oh]

(In reply to comment #4)
> Seems that media/track/track-kind.html was fixed by r195511. The other media
> track tests are still broken.
> 
> Calvaris, ChangeSeok, this seems related to your recent work; is this
> something you'd be interested in looking into?

No idea, let me look into it when I am available.

[Diego Pino]

There are no references to this bug in any TestExpectations. It's probable this bug was solved at some point but it wasn't marked as closed. I'm closing this bug now. If you think this bug report is still valid, please reopen it and add an entry to TestExpectations.