Bug 134979 - REGRESSION(r171004): [GTK] 6 Layout test on media/track/track* fail
Summary: REGRESSION(r171004): [GTK] 6 Layout test on media/track/track* fail
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-16 09:31 PDT by Carlos Alberto Lopez Perez
Modified: 2017-03-11 11:04 PST (History)
8 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-07-16 09:31:19 PDT
Revision r171004 <http://trac.webkit.org/r171004> has caused 6 failures on the media/track layout tests on the GTK port:


Regressions: Unexpected text-only failures (6)
  media/track/track-cue-mutable-text.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-mutable-text-pretty-diff.html
  media/track/track-cue-nothing-to-render.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-nothing-to-render-pretty-diff.html
  media/track/track-cue-rendering-mode-changed.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-mode-changed-pretty-diff.html
  media/track/track-cue-rendering-rtl.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-rtl-pretty-diff.html
  media/track/track-cue-rendering-snap-to-lines-not-set.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-cue-rendering-snap-to-lines-not-set-pretty-diff.html
  media/track/track-kind.html [ Failure ]
    * Diff: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r171004%20(1368)/media/track/track-kind-pretty-diff.html

I double-checked that r171004 caused this: I tested to revert r171004 locally and the tests pass as expected.
Comment 1 Brent Fulgham 2014-07-16 09:34:30 PDT
We probably need to add something like this to the generic "MediaControls.css" file: <http://trac.webkit.org/changeset/171004/trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css>

This additional <div> around the <span> might also be breaking the test you cited. You probably need to modify the test slightly so that it grabs the innerText from the right element.
Comment 2 Carlos Alberto Lopez Perez 2014-07-16 20:08:41 PDT
I have marked this test as failing on the GTK TestExpectations on r171169 <http://trac.webkit.org/r171169>
Comment 3 Marcos Chavarría Teijeiro (irc: chavaone) 2015-04-14 04:25:20 PDT
The layout test media/track/track-cue-rendering-mode-changed.html is flaky now and it timeouts sometimes.

Updating GTK test expectations on bug 143701.
Comment 4 Michael Catanzaro 2016-02-06 07:55:53 PST
Seems that media/track/track-kind.html was fixed by r195511. The other media track tests are still broken.

Calvaris, ChangeSeok, this seems related to your recent work; is this something you'd be interested in looking into?
Comment 5 ChangSeok Oh 2016-02-09 21:43:10 PST
(In reply to comment #4)
> Seems that media/track/track-kind.html was fixed by r195511. The other media
> track tests are still broken.
> 
> Calvaris, ChangeSeok, this seems related to your recent work; is this
> something you'd be interested in looking into?

No idea, let me look into it when I am available.