Add MEDIA_SOURCE option to OptionEfl.cmake and specify the video dependency.
Created attachment 234996 [details] Patch
Comment on attachment 234996 [details] Patch LGTM, but could you check what was the build error on efl ews ?
Created attachment 235070 [details] Patch update the Changelog.
Comment on attachment 235070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235070&action=review > Source/cmake/OptionsEfl.cmake:77 > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE OFF) Why do you off it in OptionsEfl.cmake ?
And isn't there any unskip test regarding media source ?
(In reply to comment #4) > (From update of attachment 235070 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235070&action=review > > > Source/cmake/OptionsEfl.cmake:77 > > +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE OFF) > > Why do you off it in OptionsEfl.cmake ? Fortunately or unfortunately, It's applied as default features if any option is supported in the Tools/Scripts/webkitperl/FeatureList.pm.
(In reply to comment #5) > And isn't there any unskip test regarding media source ? Need to check. :) However MSE is not mature for WebKit EFL yet.
*** Bug 95296 has been marked as a duplicate of this bug. ***
Comment on attachment 235070 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235070&action=review >>> Source/cmake/OptionsEfl.cmake:77 >>> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE OFF) >> >> Why do you off it in OptionsEfl.cmake ? > > Fortunately or unfortunately, It's applied as default features if any option is supported in the Tools/Scripts/webkitperl/FeatureList.pm. This option is used when we build EFL port by using cmake command directly. So need to enable it too.
(In reply to comment #9) > (From update of attachment 235070 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235070&action=review > > >>> Source/cmake/OptionsEfl.cmake:77 > >>> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_SOURCE OFF) > >> > >> Why do you off it in OptionsEfl.cmake ? > > > > Fortunately or unfortunately, It's applied as default features if any option is supported in the Tools/Scripts/webkitperl/FeatureList.pm. > > This option is used when we build EFL port by using cmake command directly. So need to enable it too. Ok, I will do it. :)
Comment on attachment 235070 [details] Patch r- due to the missing disabling MEDIA_SOURCE in OptionsEfl.cmake.
Created attachment 240677 [details] Patch
(In reply to comment #11) > Comment on attachment 235070 [details] > Patch > > r- due to the missing disabling MEDIA_SOURCE in OptionsEfl.cmake. Turn MEDIA_SOURCE on as the status of it is almost same with GTK. :)
Comment on attachment 240677 [details] Patch Patch looks good to me now. However I think we can unskip tests regarding media source. I think we have to land this patch with the tests. Could you check it ? # Requires MEDIA_SOURCE support. webkit.org/b/95296 http/tests/media/media-source [ Skip ] webkit.org/b/95296 media/media-source [ Skip ]
Created attachment 240737 [details] Patch
Created attachment 240738 [details] Patch
Comment on attachment 240738 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=240738&action=review > LayoutTests/platform/efl/TestExpectations:1115 > +webkit.org/b/134974 media/media-source/media-source-addsourcebuffer.html [ Pass ] hmm... I doubt whether you understand how to maintain failing tests on TestExpectations. All media-source tests are skipped just in above line. Thus below your update is not meaningful.
I file a new bug (Bug 143635) to enable MEDIA_SOURCE. However there are failing tests as below, http/tests/media/media-source [ Skip ] media/media-source/media-source-append-failed.html [ Timeout ] media/media-source/media-source-seek-complete.html [ Timeout ] media/media-source/media-source-stalled-holds-sleep-assertion.html [ Timeout ] media/track/track-cues-pause-on-exit.html [ Timeout ] media/media-source/media-source-duplicate-seeked.html [ Failure ] media/media-source/media-source-play.html [ Failure ] media/media-source/media-source-append-buffer-with-append-window.html [ Failure Pass ] I hope this bug tries to fix the tests.
Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this.