Bug 134968 – Move ExceptionCodeDescription.h into the files that actually need it

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Ryuan Choi]

SSIA

[Ryuan Choi]

Created attachment 234988 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 234988 [details]
Patch

r- since this patch breaks the build.

[Ryuan Choi]

Created attachment 235035 [details]
more includes

[Ryuan Choi]

Created attachment 235038 [details]
more includes2

[Darin Adler]

Comment on attachment 235038 [details]
more includes2

View in context: https://bugs.webkit.org/attachment.cgi?id=235038&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1555
> +    $implIncludes{"ExceptionCodeDescription.h"} = 1;

What port is this file for? I believe the WebKit1 GTK port is gone from the tree now, so I think that means this entire file is now obsolete, along with the WebCore/bindings/gobject and WebCore/bindings/scripts/test/GObject directories.

Another way to put this is: How did you test this change? I don’t see any changes to the expected results for gobject in WebCore/bindings/scripts/test/GObject, so I think the bindings tests will start failing.

[Ryuan Choi]

(In reply to comment #5)
> (From update of attachment 235038 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235038&action=review
> 
> > Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm:1555
> > +    $implIncludes{"ExceptionCodeDescription.h"} = 1;
> 
> What port is this file for? I believe the WebKit1 GTK port is gone from the tree now, so I think that means this entire file is now obsolete, along with the WebCore/bindings/gobject and WebCore/bindings/scripts/test/GObject directories.

I am not sure but if I am right,
WebKit2/Gtk still support DOM binding using injected bundle.

> 
> Another way to put this is: How did you test this change? I don’t see any changes to the expected results for gobject in WebCore/bindings/scripts/test/GObject, so I think the bindings tests will start failing.

I just touched for the green bot.
I believe that it is just to include header file so the compilation of gtk-wk2 bot is enough.

[WebKit Commit Bot]

Comment on attachment 235038 [details]
more includes2

Clearing flags on attachment: 235038

Committed r171285: <http://trac.webkit.org/changeset/171285>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.