Bug 134966 - [CSS Grid Layout] Add element.style coverage for grid-auto-flow
Summary: [CSS Grid Layout] Add element.style coverage for grid-auto-flow
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas (Holidays - back 1st Sep)
URL:
Keywords:
Depends on:
Blocks: 103316
  Show dependency treegraph
 
Reported: 2014-07-16 02:16 PDT by Manuel Rego Casasnovas (Holidays - back 1st Sep)
Modified: 2014-07-17 08:58 PDT (History)
3 users (show)

See Also:


Attachments
Patch (9.54 KB, patch)
2014-07-16 02:18 PDT, Manuel Rego Casasnovas (Holidays - back 1st Sep)
no flags Details | Formatted Diff | Diff
Patch (19.52 KB, patch)
2014-07-17 02:41 PDT, Manuel Rego Casasnovas (Holidays - back 1st Sep)
no flags Details | Formatted Diff | Diff
Patch (19.45 KB, patch)
2014-07-17 07:32 PDT, Manuel Rego Casasnovas (Holidays - back 1st Sep)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas (Holidays - back 1st Sep) 2014-07-16 02:16:22 PDT
We should check element.style for grid-auto-flow property in fast/css-grid-layout/grid-auto-flow-get-set.html test.

The test was modified in bug #134057 but element.style was not checked there.
Comment 1 Manuel Rego Casasnovas (Holidays - back 1st Sep) 2014-07-16 02:18:16 PDT
Created attachment 234983 [details]
Patch
Comment 2 Manuel Rego Casasnovas (Holidays - back 1st Sep) 2014-07-16 02:19:31 PDT
JFTR, this has been already landed on Blink: https://codereview.chromium.org/360233002/
Comment 3 Sergio Villar Senin 2014-07-16 02:25:46 PDT
Comment on attachment 234983 [details]
Patch

I agree with the patch but now that I see the test I think it's time to creating something like testGridDefinitionsSetJSValues() but for grid auto flow. It'd be something like checkGridDefinitionsSetJSValues() but very simplified:
{
create node
set style
match result with expected result passed as argument
remove node
}
Comment 4 Manuel Rego Casasnovas (Holidays - back 1st Sep) 2014-07-17 02:41:05 PDT
Created attachment 235060 [details]
Patch

Apply suggested changes.
Comment 5 Manuel Rego Casasnovas (Holidays - back 1st Sep) 2014-07-17 07:32:01 PDT
Created attachment 235067 [details]
Patch

Replace checkGridAutoFlowCSSSetCSSValue by checkGridAutoFlowSetCSSValue.
Comment 6 Sergio Villar Senin 2014-07-17 08:10:58 PDT
Comment on attachment 235067 [details]
Patch

Go go go!
Comment 7 WebKit Commit Bot 2014-07-17 08:58:33 PDT
Comment on attachment 235067 [details]
Patch

Clearing flags on attachment: 235067

Committed r171183: <http://trac.webkit.org/changeset/171183>
Comment 8 WebKit Commit Bot 2014-07-17 08:58:36 PDT
All reviewed patches have been landed.  Closing bug.