Bug 134928 - ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks
Summary: ScriptExecutable::forEachCodeBlock can dereference null CodeBlocks
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Hahnenberg
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-15 10:38 PDT by Mark Hahnenberg
Modified: 2014-07-15 12:12 PDT (History)
1 user (show)

See Also:


Attachments
Patch (1.74 KB, patch)
2014-07-15 10:40 PDT, Mark Hahnenberg
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Hahnenberg 2014-07-15 10:38:22 PDT
Executable::forEachCodeBlock doesn't check for null CodeBlocks in the ProgramExecutable and EvalExecutable cases, so if the CodeBlock has been cleared from either of these Executables we'll crash when dereferencing null inside whatever functor was passed.
Comment 1 Mark Hahnenberg 2014-07-15 10:40:23 PDT
Created attachment 234937 [details]
Patch
Comment 2 Andreas Kling 2014-07-15 11:02:03 PDT
Comment on attachment 234937 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-07-15 12:12:24 PDT
Comment on attachment 234937 [details]
Patch

Clearing flags on attachment: 234937

Committed r171108: <http://trac.webkit.org/changeset/171108>
Comment 4 WebKit Commit Bot 2014-07-15 12:12:27 PDT
All reviewed patches have been landed.  Closing bug.