Bug 134865 - [Cocoa] Notify the client when a navigation snapshot is taken
Summary: [Cocoa] Notify the client when a navigation snapshot is taken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-12 19:58 PDT by mitz
Modified: 2014-07-14 02:39 PDT (History)
5 users (show)

See Also:

Attachments
Add -_webView:willSnapshotBackForwardListItem: (10.91 KB, patch)
2014-07-12 20:12 PDT, mitz 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-07-12 19:58:11 PDT 
[Cocoa] Notify the client when a navigation snapshot is taken
Comment 1 mitz 2014-07-12 20:12:54 PDT 
Created attachment 234821 [details]
Add -_webView:willSnapshotBackForwardListItem:
Comment 2 WebKit Commit Bot 2014-07-12 20:15:07 PDT 
Attachment 234821 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:170:  Please declare enum bitfields as unsigned integral types.  [runtime/enum_bitfields] [5]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 mitz 2014-07-12 22:52:01 PDT 
Committed <http://trac.webkit.org/r171045>.
Comment 4 Javier Fernandez 2014-07-14 02:39:41 PDT 
This broke gtk+ build, but it has been fixed in bug #134867