Bug 134847 - Provide some large JPEG images with EXIF orientation for subsampling tests
Summary: Provide some large JPEG images with EXIF orientation for subsampling tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dean Jackson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-11 16:06 PDT by Dean Jackson
Modified: 2014-07-14 22:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (61.31 KB, patch)
2014-07-11 16:12 PDT, Dean Jackson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Jackson 2014-07-11 16:06:55 PDT
Provide some large JPEG images with EXIF orientation for subsampling tests
Comment 1 Dean Jackson 2014-07-11 16:12:02 PDT
Created attachment 234789 [details]
Patch
Comment 2 Dean Jackson 2014-07-11 16:13:39 PDT
Comment on attachment 234789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234789&action=review

> LayoutTests/ChangeLog:12
> +        Four images (either 3000x2000 or 2000x3000) that each have EXIF rotation
> +        attributes that should render with an arrow pointing UP. The
> +        orientation-rotate-0.jpg should always render correctly, even if EXIF
> +        rotation is ignored. The others are variations on that image that were
> +        saved in rotated form, then reverted to the correct orientation via EXIF.

Hmmm... I don't understand why the patch tool is showing them in their source orientation and ignoring the EXIF. If you open them in an image document, the orientation is correct. I don't know if this is a bug.
Comment 3 Tim Horton 2014-07-14 17:03:09 PDT
(In reply to comment #2)
> (From update of attachment 234789 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234789&action=review
> 
> > LayoutTests/ChangeLog:12
> > +        Four images (either 3000x2000 or 2000x3000) that each have EXIF rotation
> > +        attributes that should render with an arrow pointing UP. The
> > +        orientation-rotate-0.jpg should always render correctly, even if EXIF
> > +        rotation is ignored. The others are variations on that image that were
> > +        saved in rotated form, then reverted to the correct orientation via EXIF.
> 
> Hmmm... I don't understand why the patch tool is showing them in their source orientation and ignoring the EXIF. If you open them in an image document, the orientation is correct. I don't know if this is a bug.

That's what happens on Mac Safari at the moment.
Comment 4 WebKit Commit Bot 2014-07-14 18:37:49 PDT
Comment on attachment 234789 [details]
Patch

Clearing flags on attachment: 234789

Committed r171097: <http://trac.webkit.org/changeset/171097>
Comment 5 WebKit Commit Bot 2014-07-14 18:37:51 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Simon Fraser (smfr) 2014-07-14 22:20:56 PDT
Two things :)

1. the images should be in fast/images/resources
2. these are progressive JPEGs, which we don't try to subsample