Bug 134845 - REGRESSION (r169735): Web Inspector: Timeline tree outline missing data until collapse-expand
Summary: REGRESSION (r169735): Web Inspector: Timeline tree outline missing data until...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Timothy Hatcher
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-11 14:52 PDT by Timothy Hatcher
Modified: 2014-07-18 11:21 PDT (History)
7 users (show)

See Also:


Attachments
Bug (50.41 KB, image/png)
2014-07-11 14:53 PDT, Timothy Hatcher
no flags Details
Fixed after collapse and expand (63.46 KB, image/png)
2014-07-11 14:53 PDT, Timothy Hatcher
no flags Details
Patch (2.80 KB, patch)
2014-07-17 14:22 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Patch (5.03 KB, patch)
2014-07-17 22:51 PDT, Timothy Hatcher
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (519.66 KB, application/zip)
2014-07-18 02:55 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Timothy Hatcher 2014-07-11 14:52:55 PDT
Loading http://www.webkit.org/misc/drosera/ with the Inspector open will record a timeline. The Timeline is missing the nested timeline data for the main resource. You need to collapse and expand the main resource to see the children rows. See screenshots.
Comment 1 Radar WebKit Bug Importer 2014-07-11 14:53:08 PDT
<rdar://problem/17646599>
Comment 2 Timothy Hatcher 2014-07-11 14:53:18 PDT
Created attachment 234782 [details]
Bug
Comment 3 Timothy Hatcher 2014-07-11 14:53:38 PDT
Created attachment 234783 [details]
Fixed after collapse and expand
Comment 4 Timothy Hatcher 2014-07-11 15:02:24 PDT
Caused by https://trac.webkit.org/changeset/169735.
Comment 5 Timothy Hatcher 2014-07-11 15:57:59 PDT
Reverting r169735 fixes this. We will then need to find another fix for bug 129696.
Comment 6 Timothy Hatcher 2014-07-17 14:20:13 PDT
Reverting r169735 does not bring the other bug back. I suspect it was fixed by subsequent changes in that area (r170416 & r170389).
Comment 7 Timothy Hatcher 2014-07-17 14:22:04 PDT
Created attachment 235092 [details]
Patch
Comment 8 Timothy Hatcher 2014-07-17 14:27:56 PDT
Comment on attachment 235092 [details]
Patch

This needs more work. Finally reproduced the issue correctly.
Comment 9 Timothy Hatcher 2014-07-17 22:51:50 PDT
Created attachment 235111 [details]
Patch
Comment 10 Build Bot 2014-07-18 02:54:57 PDT
Comment on attachment 235111 [details]
Patch

Attachment 235111 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6285852082700288

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
media/track/track-long-word-container-sizing.html
Comment 11 Build Bot 2014-07-18 02:55:00 PDT
Created attachment 235120 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 12 Timothy Hatcher 2014-07-18 09:32:36 PDT
Comment on attachment 235111 [details]
Patch

Unrelated test failures. Marking cq? again.
Comment 13 Joseph Pecoraro 2014-07-18 10:48:51 PDT
Comment on attachment 235111 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235111&action=review

r=me

> Source/WebInspectorUI/ChangeLog:11
> +        (WebInspector.DOMTreeElement.prototype.adjustCollapsedRange): Use button isteand of assuming

Typo: isteand => instead
Comment 14 WebKit Commit Bot 2014-07-18 11:21:17 PDT
Comment on attachment 235111 [details]
Patch

Clearing flags on attachment: 235111

Committed r171227: <http://trac.webkit.org/changeset/171227>
Comment 15 WebKit Commit Bot 2014-07-18 11:21:21 PDT
All reviewed patches have been landed.  Closing bug.