Bug 134840 - Captions container should never clip content
Summary: Captions container should never clip content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-11 13:28 PDT by Roger Fong
Modified: 2014-07-22 09:36 PDT (History)
16 users (show)

See Also:


Attachments
patch (7.45 KB, patch)
2014-07-14 17:35 PDT, Roger Fong
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (582.95 KB, application/zip)
2014-07-14 18:42 PDT, Build Bot
no flags Details
patch (19.60 KB, patch)
2014-07-16 12:40 PDT, Roger Fong
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2014-07-11 13:28:13 PDT
If a width of the caption container is specified, a single long word can get cut off.
We would like the minimum width of the container have a value such that no words are clipped.
<rdar://problem/14553608>

The way to do this is to use the -webkit-min-content css property on min-width for the caption container.
Comment 1 Radar WebKit Bug Importer 2014-07-11 13:28:23 PDT
<rdar://problem/17645083>
Comment 2 Radar WebKit Bug Importer 2014-07-11 13:29:06 PDT
<rdar://problem/17645099>
Comment 3 Roger Fong 2014-07-14 17:35:33 PDT
Created attachment 234897 [details]
patch
Comment 4 Build Bot 2014-07-14 18:42:51 PDT
Comment on attachment 234897 [details]
patch

Attachment 234897 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4791453913972736

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
media/track/track-in-band-subtitles-too-large.html
Comment 5 Build Bot 2014-07-14 18:42:56 PDT
Created attachment 234901 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Roger Fong 2014-07-16 12:40:13 PDT
Created attachment 235016 [details]
patch
Comment 7 Simon Fraser (smfr) 2014-07-16 13:37:35 PDT
Comment on attachment 235016 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=235016&action=review

> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:712
> +    word-break: normal;

This is the default value; do you need to specify it at all?
Comment 8 Roger Fong 2014-07-16 13:46:21 PDT
(In reply to comment #7)
> (From update of attachment 235016 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=235016&action=review
> 
> > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:712
> > +    word-break: normal;
> 
> This is the default value; do you need to specify it at all?

Hmm I suppose not. I'll get rid of it and double check to make sure that there's no other style that it falls back to.
Comment 9 Roger Fong 2014-07-16 16:34:59 PDT
http://trac.webkit.org/changeset/171158
Comment 10 Alexey Proskuryakov 2014-07-16 19:35:32 PDT
This broke two tests: <http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r171166%20(7405)/results.html>.

Roger, are you available to land a fix ASAP?
Comment 11 Alexey Proskuryakov 2014-07-22 09:36:50 PDT
Tests added in this patch still fail - Roger marked them as failing on some bots, but they actually fail pretty much everywhere.

Filed bug 135160.