WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134840
Captions container should never clip content
https://bugs.webkit.org/show_bug.cgi?id=134840
Summary
Captions container should never clip content
Roger Fong
Reported
2014-07-11 13:28:13 PDT
If a width of the caption container is specified, a single long word can get cut off. We would like the minimum width of the container have a value such that no words are clipped. <
rdar://problem/14553608
> The way to do this is to use the -webkit-min-content css property on min-width for the caption container.
Attachments
patch
(7.45 KB, patch)
2014-07-14 17:35 PDT
,
Roger Fong
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2
(582.95 KB, application/zip)
2014-07-14 18:42 PDT
,
Build Bot
no flags
Details
patch
(19.60 KB, patch)
2014-07-16 12:40 PDT
,
Roger Fong
simon.fraser
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-07-11 13:28:23 PDT
<
rdar://problem/17645083
>
Radar WebKit Bug Importer
Comment 2
2014-07-11 13:29:06 PDT
<
rdar://problem/17645099
>
Roger Fong
Comment 3
2014-07-14 17:35:33 PDT
Created
attachment 234897
[details]
patch
Build Bot
Comment 4
2014-07-14 18:42:51 PDT
Comment on
attachment 234897
[details]
patch
Attachment 234897
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/4791453913972736
New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html media/track/track-in-band-subtitles-too-large.html
Build Bot
Comment 5
2014-07-14 18:42:56 PDT
Created
attachment 234901
[details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Roger Fong
Comment 6
2014-07-16 12:40:13 PDT
Created
attachment 235016
[details]
patch
Simon Fraser (smfr)
Comment 7
2014-07-16 13:37:35 PDT
Comment on
attachment 235016
[details]
patch View in context:
https://bugs.webkit.org/attachment.cgi?id=235016&action=review
> Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:712 > + word-break: normal;
This is the default value; do you need to specify it at all?
Roger Fong
Comment 8
2014-07-16 13:46:21 PDT
(In reply to
comment #7
)
> (From update of
attachment 235016
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=235016&action=review
> > > Source/WebCore/Modules/mediacontrols/mediaControlsApple.css:712 > > + word-break: normal; > > This is the default value; do you need to specify it at all?
Hmm I suppose not. I'll get rid of it and double check to make sure that there's no other style that it falls back to.
Roger Fong
Comment 9
2014-07-16 16:34:59 PDT
http://trac.webkit.org/changeset/171158
Alexey Proskuryakov
Comment 10
2014-07-16 19:35:32 PDT
This broke two tests: <
http://build.webkit.org/results/Apple%20Mavericks%20Release%20WK1%20(Tests)/r171166%20(7405)/results.html
>. Roger, are you available to land a fix ASAP?
Alexey Proskuryakov
Comment 11
2014-07-22 09:36:50 PDT
Tests added in this patch still fail - Roger marked them as failing on some bots, but they actually fail pretty much everywhere. Filed
bug 135160
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug