Bug 134827 – [EFL] Change expections for 10 failing layout tests.

• Status: RESOLVED
• Resolution: WORKSFORME
• Component: WebKit EFL

[Hunseop Jeong]

10 tests have been rebaselined, mark unexpected image-only failure.

[Hunseop Jeong]

Created attachment 234747 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 234747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234747&action=review

> LayoutTests/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=134827https://bugs.webkit.org/show_bug.cgi?id=134827

bug url is duplicated.

> LayoutTests/ChangeLog:8
> +        10 tests have been rebaselined, mark unexpected image-only failure.

r170966 was for making phone number highlight visible. So, I don't know why the revision could influence on those tests. Looks weird.

Phone number highlights should always be visible if the mouse hovers over.
<rdar://problem/17527476> and ​https://bugs.webkit.org/show_bug.cgi?id=134784

[Hunseop Jeong]

(In reply to comment #2)
> (From update of attachment 234747 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234747&action=review
> > LayoutTests/ChangeLog:4
> > +        https://bugs.webkit.org/show_bug.cgi?id=134827https://bugs.webkit.org/show_bug.cgi?id=134827
> bug url is duplicated.

Oops...

> > LayoutTests/ChangeLog:8
> > +        10 tests have been rebaselined, mark unexpected image-only failure.
> r170966 was for making phone number highlight visible. So, I don't know why the revision could influence on those tests. Looks weird.
> Phone number highlights should always be visible if the mouse hovers over.
> <rdar://problem/17527476> and ​https://bugs.webkit.org/show_bug.cgi?id=134784

This patch just fix the failure tests that is failded in layout test, it didn't related with r170966.

[Gyuyoung Kim]

Comment on attachment 234747 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234747&action=review

>>> LayoutTests/ChangeLog:8
>>> +        10 tests have been rebaselined, mark unexpected image-only failure.
>> 
>> r170966 was for making phone number highlight visible. So, I don't know why the revision could influence on those tests. Looks weird.
>> 
>> Phone number highlights should always be visible if the mouse hovers over.
>> <rdar://problem/17527476> and ​https://bugs.webkit.org/show_bug.cgi?id=134784
> 
> This patch just fix the failure tests that is failded in layout test, it didn't related with r170966.

If so, r170966 is redundant information for this rebaseline. I think you have to use more useful bug title.

[Hunseop Jeong]

Created attachment 234844 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 234844 [details]
Patch

cq+ed. It would be nicer if we mention what revision makes us to rebaseline though, nowadays it was really hard to track it because EFL bot has been broken too many times. (Many WK2 patches breaks EFL and GTK ports too many times.)

[Gyuyoung Kim]

(In reply to comment #5)
> Created an attachment (id=234844) [details]
> Patch

Before landing, I want to check if this new expected png files are same with GTK port's one.

[Hunseop Jeong]

(In reply to comment #7)
> (In reply to comment #5)
> > Created an attachment (id=234844) [details] [details]
> > Patch
> 
> Before landing, I want to check if this new expected png files are same with GTK port's one.

Yes, they are same with GTK port's one.

[WebKit Commit Bot]

Comment on attachment 234844 [details]
Patch

Rejecting attachment 234844 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 234844, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
/git.webkit.org/WebKit
   42f26e4..335ef8a  master     -> origin/master
Partial-rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc ...
Currently at 171063 = 42f26e4855f5447a6ece7ece2e2378f74dec58df
r171064 = 335ef8aca73bebffe3fd49d59ebf6cc3c8f25eca
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/4987489508917248

[Hunseop Jeong]

Jinwoo Song already rebaselined tests.
I think it should be closed.

[Ryuan Choi]

Already fixed.

http://trac.webkit.org/changeset/171064