Bug 134817 - [EFL] Build fix after r170970 and r170974
Summary: [EFL] Build fix after r170970 and r170974
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jinwoo Song
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-10 16:37 PDT by Jinwoo Song
Modified: 2014-07-10 21:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch (4.23 KB, patch)
2014-07-10 16:45 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Patch (4.41 KB, patch)
2014-07-10 17:49 PDT, Jinwoo Song 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jinwoo Song 2014-07-10 16:37:43 PDT 
Guard the Mac specific code with macro.
Comment 1 Jinwoo Song 2014-07-10 16:45:25 PDT 
Created attachment 234732 [details]
Patch
Comment 2 Tim Horton 2014-07-10 17:39:03 PDT 
Comment on attachment 234732 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234732&action=review

r+ from me for the view snapshot part, but the OpenGL part seems sufficiently platform agnostic, I'm not sure why this is needed

> Source/WebKit2/Shared/SessionState.h:31
> +#if PLATFORM(COCOA)
>  #include "ViewSnapshotStore.h"
> +#endif

This needs to go in its own block, below the rest of the includes, with a empty line separating it from the others.
Comment 3 Jinwoo Song 2014-07-10 17:49:30 PDT 
Created attachment 234734 [details]
Patch

Applied Tim's comment but waiting review for OpenGL part.
Comment 4 Jinwoo Song 2014-07-10 21:32:43 PDT 
view snapshot part is fixed by r170989 by Carlos. So I fixed OpenGL part by implementing dummy method in EFL port. (r170990)