Bug 134802 - [GTK] Reduce the size of the tarball generated by distcheck
Summary: [GTK] Reduce the size of the tarball generated by distcheck
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks:
 
Reported: 2014-07-10 09:19 PDT by Carlos Garcia Campos
Modified: 2014-07-21 01:30 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.71 KB, patch)
2014-07-10 09:25 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (3.71 KB, patch)
2014-07-10 10:14 PDT, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Updated patch (3.69 KB, patch)
2014-07-11 02:35 PDT, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2014-07-10 09:19:59 PDT
We are still including a lot of files we don't really need.
Comment 1 Carlos Garcia Campos 2014-07-10 09:25:37 PDT
Created attachment 234707 [details]
Patch

Before:
webkitgtk-2.5.1.tar.xz 13MB 15285 files

After:
webkitgtk-2.5.1.tar.xz 11MB 12829 files

Still bigger than stable:
webkitgtk-2.4.4.tar.xz 9,4MB 9994 files
Comment 2 Martin Robinson 2014-07-10 09:45:45 PDT
Comment on attachment 234707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review

> Tools/gtk/manifest.txt:51
> +exclude Source/autotools

This is unnecessary now, right?

> Tools/gtk/manifest.txt:73
> +# Inlcude only the resources we actually build

Inlcude -> Include
Comment 3 Martin Robinson 2014-07-10 09:46:23 PDT
(In reply to comment #1)
> Created an attachment (id=234707) [details]
> Patch
> 
> Before:
> webkitgtk-2.5.1.tar.xz 13MB 15285 files
> 
> After:
> webkitgtk-2.5.1.tar.xz 11MB 12829 files
> 
> Still bigger than stable:
> webkitgtk-2.4.4.tar.xz 9,4MB 9994 files


I think this 1.6 megabytes is not a huge deal. :)
Comment 4 Carlos Garcia Campos 2014-07-10 10:10:50 PDT
(In reply to comment #2)
> (From update of attachment 234707 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review
> 
> > Tools/gtk/manifest.txt:51
> > +exclude Source/autotools
> 
> This is unnecessary now, right?

That's a fix actually, it removes the trailing $

-exclude Source/autotools$
+exclude Source/autotools

to make sure it's actually excluded

> > Tools/gtk/manifest.txt:73
> > +# Inlcude only the resources we actually build
> 
> Inlcude -> Include

Oops
Comment 5 Carlos Garcia Campos 2014-07-10 10:12:10 PDT
(In reply to comment #3)
> (In reply to comment #1)
> > Created an attachment (id=234707) [details] [details]
> > Patch
> > 
> > Before:
> > webkitgtk-2.5.1.tar.xz 13MB 15285 files
> > 
> > After:
> > webkitgtk-2.5.1.tar.xz 11MB 12829 files
> > 
> > Still bigger than stable:
> > webkitgtk-2.4.4.tar.xz 9,4MB 9994 files
> 
> 
> I think this 1.6 megabytes is not a huge deal. :)

Yes, much better than the 3.6MB before, but still more than what I would like TBH.
Comment 6 Carlos Garcia Campos 2014-07-10 10:14:02 PDT
Created attachment 234709 [details]
Updated patch

Fix the typo
Comment 7 Martin Robinson 2014-07-10 10:32:03 PDT
Comment on attachment 234707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review

>>> Tools/gtk/manifest.txt:51
>>> +exclude Source/autotools
>> 
>> This is unnecessary now, right?
> 
> That's a fix actually, it removes the trailing $
> 
> -exclude Source/autotools$
> +exclude Source/autotools
> 
> to make sure it's actually excluded

Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded.
Comment 8 Carlos Garcia Campos 2014-07-10 23:05:03 PDT
(In reply to comment #7)
> (From update of attachment 234707 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review
> 
> >>> Tools/gtk/manifest.txt:51
> >>> +exclude Source/autotools
> >> 
> >> This is unnecessary now, right?
> > 
> > That's a fix actually, it removes the trailing $
> > 
> > -exclude Source/autotools$
> > +exclude Source/autotools
> > 
> > to make sure it's actually excluded
> 
> Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded.

Ah, you are right, it exists in my tree though, I guess because I switch between branches.
Comment 9 Martin Robinson 2014-07-10 23:22:45 PDT
Comment on attachment 234707 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review

>>>>> Tools/gtk/manifest.txt:51
>>>>> +exclude Source/autotools
>>>> 
>>>> This is unnecessary now, right?
>>> 
>>> That's a fix actually, it removes the trailing $
>>> 
>>> -exclude Source/autotools$
>>> +exclude Source/autotools
>>> 
>>> to make sure it's actually excluded
>> 
>> Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded.
> 
> Ah, you are right, it exists in my tree though, I guess because I switch between branches.

Hopefully that won't be an issue when your patch ensuring that only files from git are included lands.
Comment 10 Carlos Garcia Campos 2014-07-11 02:33:48 PDT
(In reply to comment #9)
> (From update of attachment 234707 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234707&action=review
> 
> >>>>> Tools/gtk/manifest.txt:51
> >>>>> +exclude Source/autotools
> >>>> 
> >>>> This is unnecessary now, right?
> >>> 
> >>> That's a fix actually, it removes the trailing $
> >>> 
> >>> -exclude Source/autotools$
> >>> +exclude Source/autotools
> >>> 
> >>> to make sure it's actually excluded
> >> 
> >> Sorry. My point is that Source/autotools doesn't even exist now, so it doesn't need to be excluded.
> > 
> > Ah, you are right, it exists in my tree though, I guess because I switch between branches.
> 
> Hopefully that won't be an issue when your patch ensuring that only files from git are included lands.

Indeed
Comment 11 Carlos Garcia Campos 2014-07-11 02:35:52 PDT
Created attachment 234751 [details]
Updated patch

Remove the rule to exclude autotools dir
Comment 12 Carlos Garcia Campos 2014-07-21 01:30:41 PDT
Committed r171296: <http://trac.webkit.org/changeset/171296>