WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134786
Web Inspector: Debugger Continue button is incorrectly sized
https://bugs.webkit.org/show_bug.cgi?id=134786
Summary
Web Inspector: Debugger Continue button is incorrectly sized
Joseph Pecoraro
Reported
2014-07-09 17:34:09 PDT
Created
attachment 234674
[details]
[IMAGE] Issue * STEPS TO REPRODUCE 1. Inspect <
http://bogojoker.com/shell/
> 2. Set a breakpoint at easySlider.js:56:21 3. Click down arrow on page to trigger breakpoint => Debugger Continue button looks sized incorrect Is this because the Dashboard View (LCD) has the debugger continue button? Do they generate a shared image with different sizes? * NOTES - This is a CSS canvas image with an explicit background size. .navigation-bar .item.debugger-pause-resume.toggle.button > .glyph { background-image: -webkit-canvas(navigation-item-debugger-pause-resume-normal); background-size: 16px 16px; }
Attachments
[IMAGE] Issue
(347.74 KB, image/png)
2014-07-09 17:34 PDT
,
Joseph Pecoraro
no flags
Details
[PATCH] Proposed Fix
(4.81 KB, patch)
2014-07-10 18:50 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2
(618.53 KB, application/zip)
2014-07-10 19:56 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-07-09 17:34:26 PDT
<
rdar://problem/17616947
>
Joseph Pecoraro
Comment 2
2014-07-10 17:33:41 PDT
So, I still have no clue why this happens. But I have a better idea of how it happens. I made the debugger controls resume button regenerate every second and played with the inspector. If the Web Inspector is wide enough to show the full DebuggerDashboardView, and if that full dashboard view is on a call frame with a very large name (like "(anonymous function) - easySlider.min.js)) causing the resume button in the DashboardView to be bad, then when the debugger controls resume button will regenerate incorrectly sized. If the Web Inspector is narrow, and it gets the narrow DebuggerDashboardView, we will always have a correctly sized button in both places. So the issue seems to be, when the dashboard view has really long text and has a poor layout, that somehow leaks out and affects the -webkit-canvas in the sidebar. I can work around this, but there will probably still be an issue in WebCore that will need to be addressed.
Joseph Pecoraro
Comment 3
2014-07-10 18:50:45 PDT
Created
attachment 234736
[details]
[PATCH] Proposed Fix This addresses numerous issues in the DebuggerDashboardView while at the same time magically fixing the pause button in the sidebar. That will still need to be tracked down and addressed, it is clearly a crazy issue.
Build Bot
Comment 4
2014-07-10 19:56:39 PDT
Comment on
attachment 234736
[details]
[PATCH] Proposed Fix
Attachment 234736
[details]
did not pass mac-wk2-ews (mac-wk2): Output:
http://webkit-queues.appspot.com/results/5288481622327296
New failing tests: media/W3C/video/src/src_reflects_attribute_not_source_elements.html
Build Bot
Comment 5
2014-07-10 19:56:42 PDT
Created
attachment 234741
[details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
WebKit Commit Bot
Comment 6
2014-07-10 22:07:20 PDT
Comment on
attachment 234736
[details]
[PATCH] Proposed Fix Clearing flags on attachment: 234736 Committed
r170991
: <
http://trac.webkit.org/changeset/170991
>
WebKit Commit Bot
Comment 7
2014-07-10 22:07:29 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug