RESOLVED FIXED 134777
[iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI 
https://bugs.webkit.org/show_bug.cgi?id=134777
Summary [iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI
Joseph Pecoraro
Reported 2014-07-09 14:24:54 PDT
Switch to UIAlertController API instead of SPI.
Attachments
[PATCH] Proposed Fix (3.30 KB, patch)
2014-07-09 14:25 PDT, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1 2014-07-09 14:25:41 PDT
Created attachment 234657 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2014-07-09 14:28:21 PDT
Attachment 234657 [details] did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:398: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:398: Missing space before { [whitespace/braces] [5] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:403: Place brace on its own line for function definitions. [whitespace/braces] [4] ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:403: Missing space before { [whitespace/braces] [5] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
WebKit Commit Bot
Comment 3 2014-07-09 21:38:37 PDT
Comment on attachment 234657 [details] [PATCH] Proposed Fix Clearing flags on attachment: 234657 Committed r170952: <http://trac.webkit.org/changeset/170952>
WebKit Commit Bot
Comment 4 2014-07-09 21:38:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.