Bug 134777 - [iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI
Summary: [iOS] Use UIAlertController API in WKFileUploadPanel instead of SPI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-09 14:24 PDT by Joseph Pecoraro
Modified: 2014-07-09 21:38 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (3.30 KB, patch)
2014-07-09 14:25 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-07-09 14:24:54 PDT 
Switch to UIAlertController API instead of SPI.
Comment 1 Joseph Pecoraro 2014-07-09 14:25:41 PDT 
Created attachment 234657 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-07-09 14:28:21 PDT 
Attachment 234657 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:392:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:398:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:398:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:403:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
ERROR: Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm:403:  Missing space before {  [whitespace/braces] [5]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-07-09 21:38:37 PDT 
Comment on attachment 234657 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 234657

Committed r170952: <http://trac.webkit.org/changeset/170952>
Comment 4 WebKit Commit Bot 2014-07-09 21:38:39 PDT 
All reviewed patches have been landed.  Closing bug.