Bug 134776 - REGRESSION(r167770): Cannot login in Evernote Safari extension
Summary: REGRESSION(r167770): Cannot login in Evernote Safari extension
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-09 13:47 PDT by Ryosuke Niwa
Modified: 2014-07-09 14:36 PDT (History)
4 users (show)

See Also:

Attachments
Partially reverts r167770 (1.81 KB, patch)
2014-07-09 13:54 PDT, Ryosuke Niwa 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2014-07-09 13:47:29 PDT 
Turns out that NSWindowDidBecomeKeyNotification and NSWindowDidResignKeyNotification
do not notify us when a popover becomes key so we need to keep using the SPI I removed.
Comment 1 Ryosuke Niwa 2014-07-09 13:54:52 PDT 
Created attachment 234654 [details]
Partially reverts r167770
Comment 2 WebKit Commit Bot 2014-07-09 14:36:38 PDT 
Comment on attachment 234654 [details]
Partially reverts r167770

Clearing flags on attachment: 234654

Committed r170931: <http://trac.webkit.org/changeset/170931>
Comment 3 WebKit Commit Bot 2014-07-09 14:36:41 PDT 
All reviewed patches have been landed.  Closing bug.