Bug 134773 - Use IOSurface ViewSnapshots everywhere on Mac, remove JPEG encoding path
Summary: Use IOSurface ViewSnapshots everywhere on Mac, remove JPEG encoding path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-09 12:17 PDT by Tim Horton
Modified: 2014-07-09 12:32 PDT (History)
3 users (show)

See Also:

Attachments
patch (12.56 KB, patch)
2014-07-09 12:21 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-07-09 12:17:50 PDT 
It's effectively unreachable code, and makes the next big patch more annoying.
Comment 1 Tim Horton 2014-07-09 12:21:53 PDT 
Created attachment 234651 [details]
patch
Comment 2 Anders Carlsson 2014-07-09 12:22:51 PDT 
Comment on attachment 234651 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234651&action=review

> Source/WebCore/platform/graphics/cocoa/IOSurface.mm:79
> +    RetainPtr<CGContextRef> surfaceContext = surface->ensurePlatformContext();

auto.
Comment 3 Tim Horton 2014-07-09 12:32:05 PDT 
http://trac.webkit.org/changeset/170925