Bug 134771 - Implement Editor::fontAttributesForSelectionStart() or iOS
Summary: Implement Editor::fontAttributesForSelectionStart() or iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-09 10:42 PDT by Enrica Casucci
Modified: 2014-07-09 12:12 PDT (History)
0 users

See Also:

Attachments
Patch (4.90 KB, patch)
2014-07-09 10:47 PDT, Enrica Casucci 		no flags Details | Formatted Diff | Diff
Patch2 (4.42 KB, patch)
2014-07-09 12:00 PDT, Enrica Casucci 		rniwa: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-07-09 10:42:19 PDT 
This bug tracks the work required to implement this function for iOS.
Comment 1 Enrica Casucci 2014-07-09 10:42:41 PDT 
<rdar://problem/16167838>
Comment 2 Enrica Casucci 2014-07-09 10:47:21 PDT 
Created attachment 234645 [details]
Patch
Comment 3 Enrica Casucci 2014-07-09 12:00:37 PDT 
Created attachment 234650 [details]
Patch2

removed unnecessary SOFT_LINK stuff
Comment 4 Ryosuke Niwa 2014-07-09 12:08:32 PDT 
Comment on attachment 234650 [details]
Patch2

View in context: https://bugs.webkit.org/attachment.cgi?id=234650&action=review

> Source/WebCore/editing/ios/EditorIOS.mm:264
> +    if (style->font().primaryFont()->getCTFont())
> +        [result setObject:(id)style->font().primaryFont()->getCTFont() forKey:NSFontAttributeName];

We should store it in a local variable inside if () instead of calling getCTFont() twice,
Comment 5 Enrica Casucci 2014-07-09 12:12:18 PDT 
Committed revision 170924.