WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134770
[Win] Remove use of 'grep' in build steps
https://bugs.webkit.org/show_bug.cgi?id=134770
Summary
[Win] Remove use of 'grep' in build steps
Brent Fulgham
Reported
2014-07-09 10:10:29 PDT
To reduce dependency on Cygwin utilities, switch from using command line 'grep' to the equivalent Perl program: perl -wnne "if (/XX%PROJECTNAME%XX/) { print } else { exit 1}" "%CONFIGURATIONBUILDDIR%\buildfailed" .... is equivalent to: grep XX%PROJECTNAME%XX "%CONFIGURATIONBUILDDIR%\buildfailed"
Attachments
Patch
(18.34 KB, patch)
2014-07-09 10:35 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(19.86 KB, patch)
2014-07-09 10:45 PDT
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(18.36 KB, patch)
2014-07-09 10:53 PDT
,
Brent Fulgham
thorton
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-07-09 10:11:13 PDT
<
rdar://problem/17608783
>
Brent Fulgham
Comment 2
2014-07-09 10:35:35 PDT
Created
attachment 234642
[details]
Patch
Brent Fulgham
Comment 3
2014-07-09 10:42:44 PDT
Comment on
attachment 234642
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=234642&action=review
> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd:4 > +if exist "%CONFIGURATIONBUILDDIR%\buildfailed" perl -wnne "if (/XX%PROJECTNAME%XX/) { print } else { exit 1}" "%CONFIGURATIONBUILDDIR%\buildfailed"
I need to correct "1}" to be "1 }"
Brent Fulgham
Comment 4
2014-07-09 10:45:47 PDT
Created
attachment 234644
[details]
Patch
Brent Fulgham
Comment 5
2014-07-09 10:52:04 PDT
Comment on
attachment 234644
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=234644&action=review
> Source/WebCore/WebCore.vcxproj/WebCoreGenerated.make:14 > + if exist "%ConfigurationBuildDir%\buildfailed" del "%ConfigurationBuildDir%\buildfailed"
Looks like line endings for this file are off.
Brent Fulgham
Comment 6
2014-07-09 10:53:13 PDT
Created
attachment 234646
[details]
Patch
Tim Horton
Comment 7
2014-07-09 10:59:59 PDT
Comment on
attachment 234646
[details]
Patch rs=me
Brent Fulgham
Comment 8
2014-07-09 11:06:05 PDT
Committed
r170922
: <
http://trac.webkit.org/changeset/170922
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug