Bug 134770 - [Win] Remove use of 'grep' in build steps
Summary: [Win] Remove use of 'grep' in build steps
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-09 10:10 PDT by Brent Fulgham
Modified: 2014-07-09 11:06 PDT (History)
2 users (show)

See Also:

Attachments
Patch (18.34 KB, patch)
2014-07-09 10:35 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (19.86 KB, patch)
2014-07-09 10:45 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (18.36 KB, patch)
2014-07-09 10:53 PDT, Brent Fulgham 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2014-07-09 10:10:29 PDT 
To reduce dependency on Cygwin utilities, switch from using command line 'grep' to the equivalent Perl program:

perl -wnne "if (/XX%PROJECTNAME%XX/) { print } else { exit 1}" "%CONFIGURATIONBUILDDIR%\buildfailed"

.... is equivalent to:

grep XX%PROJECTNAME%XX "%CONFIGURATIONBUILDDIR%\buildfailed"
Comment 1 Radar WebKit Bug Importer 2014-07-09 10:11:13 PDT 
<rdar://problem/17608783>
Comment 2 Brent Fulgham 2014-07-09 10:35:35 PDT 
Created attachment 234642 [details]
Patch
Comment 3 Brent Fulgham 2014-07-09 10:42:44 PDT 
Comment on attachment 234642 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234642&action=review

> Source/JavaScriptCore/JavaScriptCore.vcxproj/JavaScriptCorePreBuild.cmd:4
> +if exist "%CONFIGURATIONBUILDDIR%\buildfailed" perl -wnne "if (/XX%PROJECTNAME%XX/) { print } else { exit 1}" "%CONFIGURATIONBUILDDIR%\buildfailed"

I need to correct "1}" to be "1 }"
Comment 4 Brent Fulgham 2014-07-09 10:45:47 PDT 
Created attachment 234644 [details]
Patch
Comment 5 Brent Fulgham 2014-07-09 10:52:04 PDT 
Comment on attachment 234644 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234644&action=review

> Source/WebCore/WebCore.vcxproj/WebCoreGenerated.make:14
> +	if exist "%ConfigurationBuildDir%\buildfailed" del "%ConfigurationBuildDir%\buildfailed"

Looks like line endings for this file are off.
Comment 6 Brent Fulgham 2014-07-09 10:53:13 PDT 
Created attachment 234646 [details]
Patch
Comment 7 Tim Horton 2014-07-09 10:59:59 PDT 
Comment on attachment 234646 [details]
Patch

rs=me
Comment 8 Brent Fulgham 2014-07-09 11:06:05 PDT 
Committed r170922: <http://trac.webkit.org/changeset/170922>