[MSE] http/tests/media/media-source/mediasource-remove.html is failing
Created attachment 234641 [details] Patch
Comment on attachment 234641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234641&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:579 > + // and the next sync sample frame are removed. But we must start from the first sample in decode order, not > + // presentation order. Having this comment just before the code that calculates and compares removePresentationStart really confused me at first. Maybe put it after?
Comment on attachment 234641 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234641&action=review >> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:579 >> + // presentation order. > > Having this comment just before the code that calculates and compares removePresentationStart really confused me at first. Maybe put it after? Sure.
Committed r170932: <http://trac.webkit.org/changeset/170932>