Bug 134768 - [MSE] http/tests/media/media-source/mediasource-remove.html is failing
Summary: [MSE] http/tests/media/media-source/mediasource-remove.html is failing
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-09 09:05 PDT by Jer Noble
Modified: 2014-07-09 14:37 PDT (History)
7 users (show)

See Also:

Attachments
Patch (14.55 KB, patch)
2014-07-09 09:06 PDT, Jer Noble 		eric.carlson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-07-09 09:05:31 PDT 
[MSE] http/tests/media/media-source/mediasource-remove.html is failing
Comment 1 Jer Noble 2014-07-09 09:06:50 PDT 
Created attachment 234641 [details]
Patch
Comment 2 Eric Carlson 2014-07-09 10:35:08 PDT 
Comment on attachment 234641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234641&action=review

> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:579
> +        // and the next sync sample frame are removed. But we must start from the first sample in decode order, not
> +        // presentation order.

Having this comment just before the code that calculates and compares removePresentationStart really confused me at first. Maybe put it after?
Comment 3 Jer Noble 2014-07-09 13:51:20 PDT 
Comment on attachment 234641 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234641&action=review

>> Source/WebCore/Modules/mediasource/SourceBuffer.cpp:579
>> +        // presentation order.
> 
> Having this comment just before the code that calculates and compares removePresentationStart really confused me at first. Maybe put it after?

Sure.
Comment 4 Jer Noble 2014-07-09 14:37:43 PDT 
Committed r170932: <http://trac.webkit.org/changeset/170932>