Bug 134751 – [iOS][WK2] subviews of the unscaled view drift out during CA animations

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[iOS][WK2] subviews of the unscaled view drift out during CA animations

[Benjamin Poulain]

Created attachment 234618 [details]
Patch

[WebKit Commit Bot]

Attachment 234618 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:356:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:356:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Benjamin Poulain]

Comment on attachment 234618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234618&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:350
> +    if ([UIView _isInAnimationBlock] && _page->editorState().selectionIsNone && ![_highlightView superview]) {

For landing, I'll remove [_highlightView superview] and do [self _cancelInteraction] instead.

Otherwise the tap highlight animation can still cause the ugly caret issue.

[Benjamin Poulain]

Comment on attachment 234618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234618&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:104
> +    RetainPtr<UIView> _unscaledView;

Fixme: Simon would prefer the name interactionViewsContainerView.

[Enrica Casucci]

Comment on attachment 234618 [details]
Patch

Looks good to me.

[Benjamin Poulain]

Committed r170926: <http://trac.webkit.org/changeset/170926>