Bug 134751 - [iOS][WK2] subviews of the unscaled view drift out during CA animations
Summary: [iOS][WK2] subviews of the unscaled view drift out during CA animations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-08 19:31 PDT by Benjamin Poulain
Modified: 2014-07-09 12:48 PDT (History)
2 users (show)

See Also:

Attachments
Patch (13.33 KB, patch)
2014-07-08 21:20 PDT, Benjamin Poulain 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-07-08 19:31:10 PDT 
[iOS][WK2] subviews of the unscaled view drift out during CA animations
Comment 1 Benjamin Poulain 2014-07-08 21:20:32 PDT 
Created attachment 234618 [details]
Patch
Comment 2 WebKit Commit Bot 2014-07-08 21:24:56 PDT 
Attachment 234618 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:356:  More than one command on the same line  [whitespace/newline] [4]
ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:356:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Benjamin Poulain 2014-07-08 23:17:39 PDT 
Comment on attachment 234618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234618&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:350
> +    if ([UIView _isInAnimationBlock] && _page->editorState().selectionIsNone && ![_highlightView superview]) {

For landing, I'll remove [_highlightView superview] and do [self _cancelInteraction] instead.

Otherwise the tap highlight animation can still cause the ugly caret issue.
Comment 4 Benjamin Poulain 2014-07-09 12:25:51 PDT 
Comment on attachment 234618 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234618&action=review

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.h:104
> +    RetainPtr<UIView> _unscaledView;

Fixme: Simon would prefer the name interactionViewsContainerView.
Comment 5 Enrica Casucci 2014-07-09 12:28:28 PDT 
Comment on attachment 234618 [details]
Patch

Looks good to me.
Comment 6 Benjamin Poulain 2014-07-09 12:48:10 PDT 
Committed r170926: <http://trac.webkit.org/changeset/170926>