Reduce reliance on Cygwin and Bash behaviors by writing the 'auto-version' utility as a Perl script, rather than a bash script. This will make it easier to drive the build using native Windows-based utilities rather than requiring Cygwin.
Created attachment 234600 [details] Patch
<rdar://problem/17597791>
<rdar://problem/17597801>
Created attachment 234605 [details] Patch
Comment on attachment 234605 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=234605&action=review r=me > WebKitLibraries/win/tools/scripts/auto-version.pl:98 > +my $VARIANT_VERSION =$BUILD_TINY_VERSION; Nit: Space after '='. > WebKitLibraries/win/tools/scripts/auto-version.pl:104 > +if (!defined $ENVIRONMENT_VERSION) { Technically, the equivalent to "-z" would be: if (!$ENVIRONMENT_VERSION) { Not sure if that matters. (Defined returns true if the string is empty, but "!" will not, IIRC.)
(In reply to comment #5) > (From update of attachment 234605 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=234605&action=review > > r=me > > > WebKitLibraries/win/tools/scripts/auto-version.pl:98 > > +my $VARIANT_VERSION =$BUILD_TINY_VERSION; > > Nit: Space after '='. Done. > > WebKitLibraries/win/tools/scripts/auto-version.pl:104 > > +if (!defined $ENVIRONMENT_VERSION) { > > Technically, the equivalent to "-z" would be: > > if (!$ENVIRONMENT_VERSION) { > > Not sure if that matters. (Defined returns true if the string is empty, but "!" will not, IIRC.) I'll switch to your version. It may not matter, but I'd like to be as close to the bash version as possible in behavior.
This EWS bot seems broken. The file builds fine locally. I will land it and watch the bots and correct as necessary.
Committed r170905: <http://trac.webkit.org/changeset/170905>