Bug 134742 – [ftlopt] Phantom simplification should be in its own phase

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Another step towards getting rid of strange things in CSEPhase

[Filip Pizlo]

Created attachment 234594 [details]
the patch

Not ready for review because I'm still running tests.

[Filip Pizlo]

Comment on attachment 234594 [details]
the patch

It's ready for review.

[Geoffrey Garen]

Comment on attachment 234594 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234594&action=review

r=me

> Source/JavaScriptCore/dfg/DFGCleanUpPhase.cpp:43
> +class CleanUpPhase : public Phase {
> +public:
> +    CleanUpPhase(Graph& graph)
> +        : Phase(graph, "clean-up")

Would be nice to specify what we're cleaning up. PhantomCleanUpPhase?

[Filip Pizlo]

(In reply to comment #3)
> (From update of attachment 234594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234594&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGCleanUpPhase.cpp:43
> > +class CleanUpPhase : public Phase {
> > +public:
> > +    CleanUpPhase(Graph& graph)
> > +        : Phase(graph, "clean-up")
> 
> Would be nice to specify what we're cleaning up. PhantomCleanUpPhase?

I'll call it PhantomRemovalPhase

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/170907