Bug 134742 - [ftlopt] Phantom simplification should be in its own phase
Summary: [ftlopt] Phantom simplification should be in its own phase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 134677
  Show dependency treegraph
 
Reported: 2014-07-08 14:04 PDT by Filip Pizlo
Modified: 2014-07-08 20:01 PDT (History)
7 users (show)

See Also:


Attachments
the patch (22.29 KB, patch)
2014-07-08 14:08 PDT, Filip Pizlo
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-07-08 14:04:11 PDT
Another step towards getting rid of strange things in CSEPhase
Comment 1 Filip Pizlo 2014-07-08 14:08:25 PDT
Created attachment 234594 [details]
the patch

Not ready for review because I'm still running tests.
Comment 2 Filip Pizlo 2014-07-08 14:35:40 PDT
Comment on attachment 234594 [details]
the patch

It's ready for review.
Comment 3 Geoffrey Garen 2014-07-08 15:37:58 PDT
Comment on attachment 234594 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234594&action=review

r=me

> Source/JavaScriptCore/dfg/DFGCleanUpPhase.cpp:43
> +class CleanUpPhase : public Phase {
> +public:
> +    CleanUpPhase(Graph& graph)
> +        : Phase(graph, "clean-up")

Would be nice to specify what we're cleaning up. PhantomCleanUpPhase?
Comment 4 Filip Pizlo 2014-07-08 19:45:38 PDT
(In reply to comment #3)
> (From update of attachment 234594 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234594&action=review
> 
> r=me
> 
> > Source/JavaScriptCore/dfg/DFGCleanUpPhase.cpp:43
> > +class CleanUpPhase : public Phase {
> > +public:
> > +    CleanUpPhase(Graph& graph)
> > +        : Phase(graph, "clean-up")
> 
> Would be nice to specify what we're cleaning up. PhantomCleanUpPhase?

I'll call it PhantomRemovalPhase
Comment 5 Filip Pizlo 2014-07-08 20:01:03 PDT
Landed in http://trac.webkit.org/changeset/170907