Bug 134740 - [iOS] caption size is sometimes incorrect in fullscreen
Summary: [iOS] caption size is sometimes incorrect in fullscreen
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-08 13:08 PDT by Eric Carlson
Modified: 2014-07-09 10:19 PDT (History)
10 users (show)

See Also:

Attachments
Proposed patch. (13.48 KB, patch)
2014-07-08 13:34 PDT, Eric Carlson 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-07-08 13:08:30 PDT 
The font sized used for captions sometimes does not change immediately when entering full screen.
Comment 1 Eric Carlson 2014-07-08 13:34:20 PDT 
Created attachment 234589 [details]
Proposed patch.
Comment 2 Jer Noble 2014-07-08 13:53:58 PDT 
Comment on attachment 234589 [details]
Proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=234589&action=review

r=me

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        * Modules/mediacontrols/MediaControlsHost.cpp:

Nit: no description of the problem and how this patch fixes it?
Comment 3 Eric Carlson 2014-07-09 10:18:21 PDT 
(In reply to comment #2)
> (From update of attachment 234589 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=234589&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:8
> > +        Reviewed by NOBODY (OOPS!).
> > +
> > +        * Modules/mediacontrols/MediaControlsHost.cpp:
> 
> Nit: no description of the problem and how this patch fixes it?

Fixed.
Comment 4 Eric Carlson 2014-07-09 10:18:58 PDT 
Committed r170920: http://trac.webkit.org/changeset/170920