Bug 134739 - [ftlopt] Move Flush(SetLocal) store elimination to StrengthReductionPhase
Summary: [ftlopt] Move Flush(SetLocal) store elimination to StrengthReductionPhase
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 134677
  Show dependency tree / graph
 
Reported: 2014-07-08 12:41 PDT by Filip Pizlo
Modified: 2014-07-09 14:17 PDT (History)
7 users (show)

See Also:

Attachments
the patch (8.53 KB, patch)
2014-07-08 12:50 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (9.95 KB, patch)
2014-07-08 13:25 PDT, Filip Pizlo 		no flags Details | Formatted Diff | Diff
the patch (9.83 KB, patch)
2014-07-08 20:35 PDT, Filip Pizlo 		mhahnenberg: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2014-07-08 12:41:56 PDT 
I'm going to streamline CSE around clobberize(), and so Flush(SetLocal) store elimination wouldn't belong anymore.  It doesn't quite belong anywhere, which means that it belongs in StrengthReductionPhase.
Comment 1 Filip Pizlo 2014-07-08 12:50:50 PDT 
Created attachment 234584 [details]
the patch

Not yet ready for review because I'm still testing it
Comment 2 Filip Pizlo 2014-07-08 13:25:59 PDT 
Created attachment 234588 [details]
the patch
Comment 3 Filip Pizlo 2014-07-08 20:35:31 PDT 
Created attachment 234614 [details]
the patch
Comment 4 Mark Hahnenberg 2014-07-09 10:50:18 PDT 
Comment on attachment 234614 [details]
the patch

r=me
Comment 5 Filip Pizlo 2014-07-09 14:17:12 PDT 
Landed in http://trac.webkit.org/changeset/170929