Bug 134733 - Add SharedBuffer::wrapCFDataArray() and use it
Summary: Add SharedBuffer::wrapCFDataArray() and use it
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
Depends on:
Blocks: 134560
  Show dependency treegraph
Reported: 2014-07-08 10:48 PDT by Pratik Solanki
Modified: 2014-07-09 17:23 PDT (History)
6 users (show)

See Also:

Patch (10.32 KB, patch)
2014-07-08 10:50 PDT, Pratik Solanki
koivisto: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2014-07-08 10:48:35 PDT
Add SharedBuffer::wrapCFDataArray() similar to SharedBuffer::wrapCFData().
Comment 1 Pratik Solanki 2014-07-08 10:50:26 PDT
Created attachment 234573 [details]
Comment 2 Antti Koivisto 2014-07-09 11:56:30 PDT
Comment on attachment 234573 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=234573&action=review

> Source/WebCore/platform/network/mac/WebCoreResourceHandleAsDelegate.mm:200
> +    m_handle->client()->didReceiveBuffer(m_handle, SharedBuffer::wrapCFDataArrat(reinterpret_cast<CFArrayRef>(dataArray)), -1);

Typo wrapCFDataArrat

Is this change unnecessary as it doesn't seem to be compiled?
Comment 3 Pratik Solanki 2014-07-09 14:20:18 PDT
Committed r170930: <http://trac.webkit.org/changeset/170930>
Comment 4 Brent Fulgham 2014-07-09 17:03:55 PDT
This change broke the Windows build. Working on a fix.
Comment 5 Brent Fulgham 2014-07-09 17:23:33 PDT
A follow-up patch is needed to unbreak the Windows build: