I was playing with CMake on Windows and thought, "This is awesome! We have to have this." I have a few questions about the WebKit CMake system, including: Is 2.5.34 really the only version of FLEX we can use? I tried with 2.5.4, and CMakeLists.txt didn't like it. Same with ruby versioning. Do other CMake-based ports make WTF into a dynamic link library, or a static link library?
Created attachment 234547 [details] Patch
(In reply to comment #0) > Is 2.5.34 really the only version of FLEX we can use? I tried with 2.5.4, and CMakeLists.txt didn't like it. Same with ruby versioning. I expect that it would be not too much work to adapt our CMake scripts to work with both the old and new versions of the utilities, but I don't know the details. > Do other CMake-based ports make WTF into a dynamic link library, or a static link library? We compile WTF as a static object, but this would be easy to make configurable. The line that controls this is add_library(WTF STATIC ${WTF_HEADERS} ${WTF_SOURCES}) in Source/WTF/wtf/CMakeLists.txt.
Comment on attachment 234547 [details] Patch I would really love to see this working.
Comment on attachment 234547 [details] Patch Attachment 234547 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5388266127753216 New failing tests: media/W3C/video/networkState/networkState_during_loadstart.html
Created attachment 234549 [details] Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-10 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Comment on attachment 234547 [details] Patch Clearing flags on attachment: 234547 Committed r170892: <http://trac.webkit.org/changeset/170892>
All reviewed patches have been landed. Closing bug.