Bug 134711 - WKProcessPoolConfigurationPrivate's maximumProcessCount property has no effect
Summary: WKProcessPoolConfigurationPrivate's maximumProcessCount property has no effect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-07 19:06 PDT by Tim Horton
Modified: 2014-07-08 12:28 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.52 KB, patch)
2014-07-08 12:19 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-07-07 19:06:52 PDT 
Because nothing ever reads from it!

It would also be nice if MiniBrowser had a maximumProcessCount=1 mode; frequently useful for debugging things where having two pages in one process is important.
Comment 1 Tim Horton 2014-07-07 20:00:30 PDT 
Huh, I see no indication that there's a process cap by default. I thought it was 20 or some such?
Comment 2 Tim Horton 2014-07-08 12:19:57 PDT 
Created attachment 234581 [details]
patch
Comment 3 mitz 2014-07-08 12:22:38 PDT 
Comment on attachment 234581 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234581&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKProcessPool.mm:173
> +    _context->setMaximumNumberOfProcesses(configuration.maximumProcessCount);

Everywhere else in this method we use the instance variable _configuration, not the parameter.
Comment 4 Tim Horton 2014-07-08 12:28:43 PDT 
http://trac.webkit.org/changeset/170893