Bug 134709 - Remove WebBackForwardListItems when their owning page goes away
Summary: Remove WebBackForwardListItems when their owning page goes away
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-07 18:54 PDT by Tim Horton
Modified: 2014-07-08 16:18 PDT (History)
5 users (show)

See Also:

Attachments
patch (15.73 KB, patch)
2014-07-08 13:37 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
patch (14.42 KB, patch)
2014-07-08 15:48 PDT, Tim Horton 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-07-07 18:54:57 PDT 
Currently, WebProcessProxy holds on to them even after the WebPageProxy disappears.
Comment 1 Radar WebKit Bug Importer 2014-07-07 18:55:19 PDT 
<rdar://problem/17584645>
Comment 2 Tim Horton 2014-07-08 13:37:22 PDT 
Created attachment 234591 [details]
patch
Comment 3 Tim Horton 2014-07-08 15:48:06 PDT 
Created attachment 234602 [details]
patch
Comment 4 mitz 2014-07-08 15:55:28 PDT 
Comment on attachment 234602 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234602&action=review

> Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:107
> +    ItemAndPageID ids;
> +    ids.itemID = itemID;
> +    ids.pageID = pageID;
> +    
> +    historyItemToIDMap().set(item, ids);

Isn’t there a way to do this without the named variable?

> Source/WebKit2/WebProcess/WebPage/WebBackForwardListProxy.cpp:166
> +    historyItemToIDMap().set(item, ids);

Ditto.
Comment 5 Tim Horton 2014-07-08 16:18:06 PDT 
http://trac.webkit.org/changeset/170902