WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134701
[UI-side compositing] Support reflections on custom layers like video
https://bugs.webkit.org/show_bug.cgi?id=134701
Summary
[UI-side compositing] Support reflections on custom layers like video
Simon Fraser (smfr)
Reported
2014-07-07 16:22:41 PDT
[UI-side compositing] Support reflections on custom layers like video
Attachments
Patch
(27.52 KB, patch)
2014-07-07 16:31 PDT
,
Simon Fraser (smfr)
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1
2014-07-07 16:31:07 PDT
Created
attachment 234525
[details]
Patch
Tim Horton
Comment 2
2014-07-07 16:38:44 PDT
Comment on
attachment 234525
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=234525&action=review
> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:183 > + if ([layer isKindOfClass:[NSClassFromString(@"WebGLLayer") class]])
we talked about this
> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:221 > + // We don't create PlatformCALayerMac's wrapped around WebGLLayers.
weird apostrophe
> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:50 > + PlatformCALayerRemoteCustom(WebCore::PlatformCALayer::LayerType, PlatformLayer*, WebCore::PlatformCALayerClient* owner, RemoteLayerTreeContext&);
star's on the wrong side
Simon Fraser (smfr)
Comment 3
2014-07-07 16:46:09 PDT
https://trac.webkit.org/r170864
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug