Bug 134701 - [UI-side compositing] Support reflections on custom layers like video
Summary: [UI-side compositing] Support reflections on custom layers like video
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-07 16:22 PDT by Simon Fraser (smfr)
Modified: 2014-07-07 16:46 PDT (History)
3 users (show)

See Also:

Attachments
Patch (27.52 KB, patch)
2014-07-07 16:31 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-07-07 16:22:41 PDT 
[UI-side compositing] Support reflections on custom layers like video
Comment 1 Simon Fraser (smfr) 2014-07-07 16:31:07 PDT 
Created attachment 234525 [details]
Patch
Comment 2 Tim Horton 2014-07-07 16:38:44 PDT 
Comment on attachment 234525 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234525&action=review

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:183
> +    if ([layer isKindOfClass:[NSClassFromString(@"WebGLLayer") class]])

we talked about this

> Source/WebCore/platform/graphics/ca/mac/PlatformCALayerMac.mm:221
> +        // We don't create PlatformCALayerMac's wrapped around WebGLLayers.

weird apostrophe

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemoteCustom.h:50
> +    PlatformCALayerRemoteCustom(WebCore::PlatformCALayer::LayerType, PlatformLayer*, WebCore::PlatformCALayerClient* owner, RemoteLayerTreeContext&);

star's on the wrong side
Comment 3 Simon Fraser (smfr) 2014-07-07 16:46:09 PDT 
https://trac.webkit.org/r170864