Bug 134700 - Ensure we compute the height of replaced elements to 'auto' when appropriate.
Summary: Ensure we compute the height of replaced elements to 'auto' when appropriate.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Bem Jones-Bey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-07-07 16:05 PDT by Bem Jones-Bey
Modified: 2014-07-08 15:11 PDT (History)
6 users (show)

See Also:


Attachments
Patch (8.26 KB, patch)
2014-07-08 09:21 PDT, Bem Jones-Bey
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2 (539.18 KB, application/zip)
2014-07-08 10:33 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (504.41 KB, application/zip)
2014-07-08 11:53 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bem Jones-Bey 2014-07-07 16:05:27 PDT
Ensure we compute the height of replaced elements to 'auto' when appropriate.
Comment 1 Bem Jones-Bey 2014-07-08 09:15:40 PDT
This is based on two Blink commits:

https://codereview.chromium.org/347053007
https://codereview.chromium.org/359673003
Comment 2 Bem Jones-Bey 2014-07-08 09:21:52 PDT
Created attachment 234566 [details]
Patch
Comment 3 Build Bot 2014-07-08 10:33:37 PDT
Comment on attachment 234566 [details]
Patch

Attachment 234566 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6155536265379840

New failing tests:
media/W3C/video/networkState/networkState_during_loadstart.html
Comment 4 Build Bot 2014-07-08 10:33:39 PDT
Created attachment 234570 [details]
Archive of layout-test-results from webkit-ews-10 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-10  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 5 Build Bot 2014-07-08 11:53:11 PDT
Comment on attachment 234566 [details]
Patch

Attachment 234566 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4982631162707968

New failing tests:
media/video-ended-event-negative-playback.html
Comment 6 Build Bot 2014-07-08 11:53:14 PDT
Created attachment 234578 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 7 Bem Jones-Bey 2014-07-08 14:19:04 PDT
Both of those failed tests run fine for me locally on 10.9.4. (both Debug and Release builds) I don't currently see any way that this change could have caused these tests to timeout.
Comment 8 Dave Hyatt 2014-07-08 14:21:22 PDT
Comment on attachment 234566 [details]
Patch

r=me
Comment 9 Bem Jones-Bey 2014-07-08 14:31:23 PDT
Comment on attachment 234566 [details]
Patch

Lets roll the dice with the CQ.
Comment 10 WebKit Commit Bot 2014-07-08 15:11:07 PDT
Comment on attachment 234566 [details]
Patch

Clearing flags on attachment: 234566

Committed r170895: <http://trac.webkit.org/changeset/170895>
Comment 11 WebKit Commit Bot 2014-07-08 15:11:13 PDT
All reviewed patches have been landed.  Closing bug.