Represented object types: console.assert(representedObject instanceof WebInspector.DOMSearchMatchObject || representedObject instanceof WebInspector.ResourceSearchMatchObject); Seems like we should avoid having a saved cookie for search results.
Full console log was: [Error] Error: TreeElement.representedObject is missing a saveIdentityToCookie implementation. TreeElement.constructor: function (representedObject) { console.assert(representedObject instanceof WebInspector.DOMSearchMatchObject || representedObject instanceof WebInspector.ResourceSearchMatchObject); var title = WebInspector.SearchResultTreeElement.truncateAndHighlightTitle(representedObject.title, representedObject.searchTerm, representedObject.sourceCodeTextRange); WebInspector.GeneralTreeElement.call(this, representedObject.className, title, null, representedObject, false); this.small = true; } Meaning it was WebInspector.SearchResultTreeElement represented object types listed in the above comment.
<rdar://problem/17581638>
<rdar://problem/17581640>
Test comment.
* STEPS TO REPRODUCE 1. Inspect <http://bogojoker.com> 2. Shift+Cmd+F for global search "div" 3. Select any result (text result or DOM result) 5. Cmd+R Reload => error and sidebar is empty, it hasn't re-triggered the search or cleared the search
Also, the backtrace is: [Error] Error: TreeElement.representedObject is missing a saveIdentityToCookie implementation.... saveStateToCookie (Main.js, line 4379) _updateCookieForInspectorViewState (Main.js, line 10938) _provisionalLoadStarted (Main.js, line 10853) dispatch (Main.js, line 67) dispatchEventToListeners (Main.js, line 69) startProvisionalLoad (Main.js, line 1947) _addResourceToFrame (Main.js, line 10293) _addNewResourceToFrame (Main.js, line 10288) resourceRequestWillBeSent (Main.js, line 10248) requestWillBeSent (Main.js, line 716) dispatchEvent (Main.js, line 605) _dispatchEvent (Main.js, line 583) dispatch (Main.js, line 556) dispatchNextQueuedMessageFromBackend (Main.js, line 707)
(In reply to comment #5) > * STEPS TO REPRODUCE > 1. Inspect <http://bogojoker.com> > 2. Shift+Cmd+F for global search "div" > 3. Select any result (text result or DOM result) > 4. Cmd+R Reload > => error and sidebar is empty, it hasn't re-triggered the search or Better steps here for testing is to replace step 4: 4. Close Inspector 5. Open Inspector => ensure same search tree item is selected. Now, we still should fix the scenario above for search term, but that can be handled separately. I have a fix for saveIdentityToCookie here, testable with these steps.
Created attachment 248399 [details] [PATCH] Proposed Fix
Comment on attachment 248399 [details] [PATCH] Proposed Fix Clearing flags on attachment: 248399 Committed r181386: <http://trac.webkit.org/changeset/181386>
All reviewed patches have been landed. Closing bug.