Bug 134697 - Remove misleadingly-named Font::isSVGFont()
Summary: Remove misleadingly-named Font::isSVGFont()
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
Depends on:
Reported: 2014-07-07 15:10 PDT by Myles C. Maxfield
Modified: 2014-07-07 19:27 PDT (History)
15 users (show)

See Also:

Patch (7.99 KB, patch)
2014-07-07 15:13 PDT, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2014-07-07 15:10:24 PDT
Remove misleadingly-named Font::isSVGFont()
Comment 1 Myles C. Maxfield 2014-07-07 15:13:02 PDT
Created attachment 234516 [details]
Comment 2 Darin Adler 2014-07-07 16:17:05 PDT
Comment on attachment 234516 [details]

What guarantees that primaryFont is non-null at all these call sites?
Comment 3 Myles C. Maxfield 2014-07-07 16:44:26 PDT
I don't believe there is any, other than that the existing code already dereferences these pointers. Do you have an opinion about how I should do this differently?
Comment 4 WebKit Commit Bot 2014-07-07 19:27:38 PDT
Comment on attachment 234516 [details]

Clearing flags on attachment: 234516

Committed r170871: <http://trac.webkit.org/changeset/170871>
Comment 5 WebKit Commit Bot 2014-07-07 19:27:43 PDT
All reviewed patches have been landed.  Closing bug.