Bug 134695 - add css jit profiler
Summary: add css jit profiler
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on: 134749
Blocks:
  Show dependency tree / graph
 
Reported: 2014-07-07 14:53 PDT by Alex Christensen
Modified: 2014-07-09 10:51 PDT (History)
9 users (show)

See Also:

Attachments
Patch (9.06 KB, patch)
2014-07-07 14:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (9.45 KB, patch)
2014-07-07 15:25 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-07-07 14:53:43 PDT 
Profiling the css jit compiler is useful to know where we need to improve.
Comment 1 Alex Christensen 2014-07-07 14:54:27 PDT 
Created attachment 234513 [details]
Patch
Comment 2 Alex Christensen 2014-07-07 15:25:45 PDT 
Created attachment 234519 [details]
Patch
Comment 3 WebKit Commit Bot 2014-07-08 14:48:18 PDT 
Comment on attachment 234519 [details]
Patch

Clearing flags on attachment: 234519

Committed r170894: <http://trac.webkit.org/changeset/170894>
Comment 4 WebKit Commit Bot 2014-07-08 14:48:22 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2014-07-08 17:41:30 PDT 
Re-opened since this is blocked by bug 134749
Comment 6 Alex Christensen 2014-07-08 22:40:45 PDT 
Comment on attachment 234519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234519&action=review

> Source/WebCore/cssjit/SelectorCompiler.h:34
> +#define CSS_SELECTOR_JIT_PROFILING 1

Here's the problem.  This should be 0.  I'll recommit this tomorrow with 0 and watch the bots.
Comment 7 Alex Christensen 2014-07-09 10:45:27 PDT 
Comment on attachment 234519 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=234519&action=review

> Source/WebCore/css/RuleSet.cpp:143
> +#if CSS_SELECTOR_JIT_PROFILING

Ah, this should be ENABLE(CSS_SELECTOR_JIT) && CSS_SELECTOR_JIT_PROFILING

> Source/WebCore/dom/SelectorQuery.h:59
> +#if CSS_SELECTOR_JIT_PROFILING

this, too.
Comment 8 Alex Christensen 2014-07-09 10:51:22 PDT 
Re-committed to http://trac.webkit.org/changeset/170921 and watching bots...