134683 – fix nested function crash on iOS

RESOLVED FIXED 134683

fix nested function crash on iOS

https://bugs.webkit.org/show_bug.cgi?id=134683

Summary fix nested function crash on iOS

Alex Christensen

Reported 2014-07-07 10:13:28 PDT

I verified that this fixes the WebGL crash in the nested-functions-should-not-crash.html test.

Attachments
Patch (1.85 KB, patch) 2014-07-07 10:15 PDT, Alex Christensen	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Alex Christensen

Comment 1 2014-07-07 10:13:50 PDT

<rdar://problem/17541529>

Alex Christensen

Comment 2 2014-07-07 10:15:54 PDT

Created attachment 234491 [details] Patch

Geoffrey Garen

Comment 3 2014-07-07 10:59:05 PDT

Comment on attachment 234491 [details] Patch r=me Is there a performance cost to this limit?

Alex Christensen

Comment 4 2014-07-07 11:05:56 PDT

(In reply to comment #3) > (From update of attachment 234491 [details]) > r=me > > Is there a performance cost to this limit? If someone has a shader with more than 256 nested functions, it will no longer compile. I don't think there's a performance hit because this only changes the shader validator, and I think the call depth is counted anyway. It just wasn't used without this change.

WebKit Commit Bot

Comment 5 2014-07-07 11:21:39 PDT

Comment on attachment 234491 [details] Patch Clearing flags on attachment: 234491 Committed r170849: <http://trac.webkit.org/changeset/170849>

WebKit Commit Bot

Comment 6 2014-07-07 11:21:42 PDT

All reviewed patches have been landed. Closing bug.

WebKit Commit Bot

Comment 7 2014-07-08 17:37:38 PDT

Re-opened since this is blocked by bug 134748

Alex Christensen

Comment 8 2014-07-09 10:28:17 PDT

this did not break the build and it was not rolled out. reclosing.

Note You need to log in before you can comment on or make changes to this bug.