Bug 134678 - Some of the WKPreferences (API) property getters read like questions
Summary: Some of the WKPreferences (API) property getters read like questions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-07-06 23:07 PDT by Tim Horton
Modified: 2014-07-07 15:41 PDT (History)
4 users (show)

See Also:

Attachments
Patch (3.22 KB, patch)
2014-07-07 12:06 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (3.23 KB, patch)
2014-07-07 12:47 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-07-06 23:07:28 PDT 
Specifically, Dan calls these three out in https://bugs.webkit.org/show_bug.cgi?id=134645#c8:

@property (nonatomic, getter=isJavaScriptEnabled) BOOL javaScriptEnabled;
@property (nonatomic, getter=isJavaEnabled) BOOL javaEnabled;
@property (nonatomic, getter=arePlugInsEnabled) BOOL plugInsEnabled;

See the discussion in that bug for potential alternatives.
Comment 1 Radar WebKit Bug Importer 2014-07-07 11:05:41 PDT 
<rdar://problem/17576847>
Comment 2 Anders Carlsson 2014-07-07 12:06:07 PDT 
Created attachment 234500 [details]
Patch
Comment 3 Anders Carlsson 2014-07-07 12:47:48 PDT 
Created attachment 234502 [details]
Patch
Comment 4 Anders Carlsson 2014-07-07 12:52:46 PDT 
Committed r170853: <http://trac.webkit.org/changeset/170853>
Comment 5 Darin Adler 2014-07-07 15:41:39 PDT 
You silently fixed incorrect header documentation too. Was that intentional?