WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
134678
Some of the WKPreferences (API) property getters read like questions
https://bugs.webkit.org/show_bug.cgi?id=134678
Summary
Some of the WKPreferences (API) property getters read like questions
Tim Horton
Reported
2014-07-06 23:07:28 PDT
Specifically, Dan calls these three out in
https://bugs.webkit.org/show_bug.cgi?id=134645#c8
: @property (nonatomic, getter=isJavaScriptEnabled) BOOL javaScriptEnabled; @property (nonatomic, getter=isJavaEnabled) BOOL javaEnabled; @property (nonatomic, getter=arePlugInsEnabled) BOOL plugInsEnabled; See the discussion in that bug for potential alternatives.
Attachments
Patch
(3.22 KB, patch)
2014-07-07 12:06 PDT
,
Anders Carlsson
no flags
Details
Formatted Diff
Diff
Patch
(3.23 KB, patch)
2014-07-07 12:47 PDT
,
Anders Carlsson
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2014-07-07 11:05:41 PDT
<
rdar://problem/17576847
>
Anders Carlsson
Comment 2
2014-07-07 12:06:07 PDT
Created
attachment 234500
[details]
Patch
Anders Carlsson
Comment 3
2014-07-07 12:47:48 PDT
Created
attachment 234502
[details]
Patch
Anders Carlsson
Comment 4
2014-07-07 12:52:46 PDT
Committed
r170853
: <
http://trac.webkit.org/changeset/170853
>
Darin Adler
Comment 5
2014-07-07 15:41:39 PDT
You silently fixed incorrect header documentation too. Was that intentional?
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug