Gamepad LayoutTest support While we won't be able to automatically test physical gamepad connects/disconnects, virtual ones are doable. We need to write a dummy GamepadProvider with a javascript interface that lets us test the Gamepad DOM mechanism.
Have a patch in progress on this I hope to get uploaded tomorrow.
Created attachment 237906 [details] Patch v1 - For EWS, not ready for review
Created attachment 237915 [details] Patch v2 - Better feature guards
This approach is semi-outdated and will be revisited soon.
Retitling: WK2 Gamepad layout test support
Created attachment 286618 [details] Patch
Comment on attachment 286618 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286618&action=review > Source/WebCore/testing/MockGamepadProvider.h:67 > + bool m_shouldScheduleActivityCallback; { true }
Created attachment 286628 [details] Patch
Comment on attachment 286628 [details] Patch Attachment 286628 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1923316 New failing tests: fast/dom/navigator-detached-no-crash.html
Created attachment 286634 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 286637 [details] Patch
Created attachment 286638 [details] Patch
Comment on attachment 286638 [details] Patch Attachment 286638 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/1923975 New failing tests: fast/dom/navigator-detached-no-crash.html
Created attachment 286643 [details] Archive of layout-test-results from ews107 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews107 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Comment on attachment 286638 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=286638&action=review Looks pretty good. EWS still not happy. Will Check in the morning > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:36 > +GamepadData::GamepadData(unsigned index, const Vector<double>& axisValues, const Vector<double>& buttonValues) Could we make this take a Vector&&? > Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:28 > +LD_RUNPATH_SEARCH_PATHS = "@loader_path"; What's this? > Tools/WebKitTestRunner/TestInvocation.cpp:689 > + :(
Created attachment 286716 [details] Patch
Created attachment 286719 [details] Patch
(In reply to comment #15) > Comment on attachment 286638 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=286638&action=review > > Looks pretty good. EWS still not happy. Will Check in the morning > > > Source/WebKit2/Shared/Gamepad/GamepadData.cpp:36 > > +GamepadData::GamepadData(unsigned index, const Vector<double>& axisValues, const Vector<double>& buttonValues) > > Could we make this take a Vector&&? Would have no benefit. > > > Tools/WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig:28 > > +LD_RUNPATH_SEARCH_PATHS = "@loader_path"; > > What's this? xcode nonsense to get the UI Process linking with WebCoreTestSupport. > > Tools/WebKitTestRunner/TestInvocation.cpp:689 > > + > > :( :(
Created attachment 286720 [details] Patch
Created attachment 286721 [details] Patch
Created attachment 286722 [details] Patch
Comment on attachment 286722 [details] Patch Clearing flags on attachment: 286722 Committed r204853: <http://trac.webkit.org/changeset/204853>
All reviewed patches have been landed. Closing bug.