Bug 134669 - DOMWindows should register themselves with the GamepadManager when they have event listeners
Summary: DOMWindows should register themselves with the GamepadManager when they have ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords:
Depends on:
Blocks: 134386
  Show dependency tree / graph
 
Reported: 2014-07-06 17:08 PDT by Brady Eidson
Modified: 2014-07-08 23:51 PDT (History)
4 users (show)

See Also:

Attachments
Patch v1 (10.78 KB, patch)
2014-07-06 17:27 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v1a (rebased, ready to EWS) (10.73 KB, patch)
2014-07-07 19:37 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-07-06 17:08:59 PDT 
DOMWindows should register themselves with the GamepadManager when they have event listeners

This will let us easily target all DOMWindows that might listen to gamepad events, as well as help us know when we should be listening for new gamepad connections.
Comment 1 Brady Eidson 2014-07-06 17:27:34 PDT 
Created attachment 234471 [details]
Patch v1

This patch relies on the patch in 134670, so it probably won't apply right now.  I'm just attaching it for posterity.
Comment 2 Brady Eidson 2014-07-07 19:37:08 PDT 
Created attachment 234538 [details]
Patch v1a (rebased, ready to EWS)
Comment 3 WebKit Commit Bot 2014-07-07 19:38:21 PDT 
Attachment 234538 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/EventNames.h:285:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
ERROR: Source/WebCore/dom/EventNames.h:288:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 2 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Brady Eidson 2014-07-07 20:40:45 PDT 
(In reply to comment #3)
> Attachment 234538 [details] did not pass style-queue:
> 
> 
> ERROR: Source/WebCore/dom/EventNames.h:285:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> ERROR: Source/WebCore/dom/EventNames.h:288:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
> Total errors found: 2 in 6 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

While these macro newlines and comments are non-standard style, they're quite consistent within this file. =/
Comment 5 WebKit Commit Bot 2014-07-08 23:50:59 PDT 
Comment on attachment 234538 [details]
Patch v1a (rebased, ready to EWS)

Clearing flags on attachment: 234538

Committed r170911: <http://trac.webkit.org/changeset/170911>
Comment 6 WebKit Commit Bot 2014-07-08 23:51:03 PDT 
All reviewed patches have been landed.  Closing bug.